Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Michael Snyder <msnyder@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Reverse debugging, part 3/3: user interface / docs
Date: Tue, 18 Apr 2006 09:15:00 -0000	[thread overview]
Message-ID: <ulku3xn0j.fsf@gnu.org> (raw)
In-Reply-To: <44442877.1060401@redhat.com> (message from Michael Snyder on 	Mon, 17 Apr 2006 16:44:55 -0700)

> Date: Mon, 17 Apr 2006 16:44:55 -0700
> From: Michael Snyder <msnyder@redhat.com>
> CC: gdb-patches@sources.redhat.com
> 
> Please see revised patch, attached.
> OK now?

The corrections you made are okay, but you left two of my suggestions
unhandled, please at least explain why.

> >>+                                                 Behavior of 
> >>+ asynchronous signals depends on the target environment.
> > 
> > 
> > This is too vague.  Can we at least mention the possible behaviors, or
> > just the most common/expected ones?  The reader should get some idea
> > of what might happen.

You didn't change anything in response to this comment.

> >>+ Run the program backward until control reaches the start of a
> >>+ different source line
> > 
> > 
> > Isn't it better to say
> > 
> >   Run the program backwards until control reaches the first instruction
> >   of a different source line
> > 
> > ?  In any case, "backwards", not "backward".

You left "backward" in the text.


  reply	other threads:[~2006-04-18  9:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <442DAAD9.6080509@redhat.com>
2006-04-01 13:05 ` Eli Zaretskii
2006-04-03 19:27   ` Michael Snyder
2006-04-17 23:45   ` Michael Snyder
2006-04-18  9:15     ` Eli Zaretskii [this message]
2006-04-18 18:56       ` Michael Snyder
2006-04-19  7:38         ` Eli Zaretskii
2006-04-19 18:33           ` Michael Snyder
2006-04-20  9:21             ` Eli Zaretskii
2006-04-20 16:07     ` Daniel Jacobowitz
2006-04-20 22:54       ` Michael Snyder
2006-04-24 20:47         ` Daniel Jacobowitz
2006-04-29  0:37           ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ulku3xn0j.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=msnyder@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox