Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@redhat.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sources.redhat.com
Subject: Re: [RFA] Reverse debugging, part 3/3: user interface / docs
Date: Sat, 29 Apr 2006 00:37:00 -0000	[thread overview]
Message-ID: <4452B548.7030502@redhat.com> (raw)
In-Reply-To: <20060424204705.GA27220@nevyn.them.org>

Daniel Jacobowitz wrote:
> On Thu, Apr 20, 2006 at 03:54:15PM -0700, Michael Snyder wrote:
> 
>>Daniel Jacobowitz wrote:
>>
>>>FWIW, I've got no opinions on this patch.  The content looks fine.  My
>>>only concern is that I don't much like "set" variables which succeed or
>>>fail depending on the target - we can switch targets unexpectedly.
>>>
>>>Can we just give the error in proceed if the target can't run in
>>>reverse?
>>
>>You mean, "and not give an error when you say "set exec-dir"?
>>
>>Well here's the thing: I've had experience with something
>>very similar*, and the users complained.  They wanted to
>>know sooner if there was a problem.
>>
>>* Tracepoints.  You don't find out that the remote target can't
>>support them until you say continue.
> 
> 
> Sorry about the delay; I started replying to this on Thursday but
> didn't finish it before I headed out for a long weekend.

My turn to appologize.  Been implementing some of your other suggestions.

> I agree that, as user interface, this is unpleasant.  But here's some
> of the other cases we have to consider.
> 
> (gdb) set exec-dir reverse
> (gdb) target remote :1234
> 
> -> Should it work before you're connected?

To my present way of thinking, no.  It's target dependent,
it can't work before you set the target.  There are other
commands that won't work without a target, notably "run"
(except in the native case), or "info threads".

> (gdb) target remote :1234
> (gdb) set exec-dir reverse
> (gdb) disconnect
> (gdb) run
> 
> -> Where do we get the error now?  We've switched targets, "run" can't
> go in reverse for target child.

Well, there you've got me.  That's a problem.

> 
> And as we've already seen, your error doesn't actually come at the
> right time, since your remote protocol doesn't have a probe packet!
> So remote will always let it succeed and child will always make it
> fail, regardless of whether the remote target actually supports it.
> 
> That's mighty inconsistent.  I'm open to suggestions on a more
> consistent way to present the problem.

I'm stumped -- I can think of only two approaches:
1) add a probe packet, or
2) throw out the "set exec-dir" user interface (just use "rs" etc.).

I don't like to throw out the user interface without a fight,
'cause I find it a fairly intuitive interface.  So... maybe
this forces us to add a probe?




      reply	other threads:[~2006-04-29  0:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <442DAAD9.6080509@redhat.com>
2006-04-01 13:05 ` Eli Zaretskii
2006-04-03 19:27   ` Michael Snyder
2006-04-17 23:45   ` Michael Snyder
2006-04-18  9:15     ` Eli Zaretskii
2006-04-18 18:56       ` Michael Snyder
2006-04-19  7:38         ` Eli Zaretskii
2006-04-19 18:33           ` Michael Snyder
2006-04-20  9:21             ` Eli Zaretskii
2006-04-20 16:07     ` Daniel Jacobowitz
2006-04-20 22:54       ` Michael Snyder
2006-04-24 20:47         ` Daniel Jacobowitz
2006-04-29  0:37           ` Michael Snyder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4452B548.7030502@redhat.com \
    --to=msnyder@redhat.com \
    --cc=drow@false.org \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox