Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Jim Blandy <jimb@red-bean.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: GDB manual: document tracepoint packets
Date: Sun, 20 Nov 2005 14:57:00 -0000	[thread overview]
Message-ID: <uk6f4fe2f.fsf@gnu.org> (raw)
In-Reply-To: <8f2776cb0511191231y11805c1bqb4b4eb426b0e31fa@mail.gmail.com> 	(message from Jim Blandy on Sat, 19 Nov 2005 12:31:20 -0800)

> Date: Sat, 19 Nov 2005 12:31:20 -0800
> From: Jim Blandy <jimb@red-bean.com>
> 
> 2005-11-19  Jim Blandy  <jimb@redhat.com>
> 
> 	* gdb.texinfo (Tracepoint Packets): New node.
> 	(General Query Packets): Add entries for the tracepoint packets,
> 	referring to the "Tracepoint Packets" node.

Thanks.  My comments are below.

> + @node Tracepoint Packets
> + @section Tracepoint Packets

Suggest a @cindex entry here, something like "tracepoint packets".

> + Here we describe the packets @value{GDBN} uses to implement
> + tracepoints (@pxref{Tracepoints}).

I think it would be good to have an @xref from the "Tracepoints" node
to here as well.

> + Replies:
> + @table @samp
> + @item OK
> + The packet was understood and carried out.
> + @item 

Does this @item really need to be empty?  If so, why, and what do we
want to appear here in print?

> + @item 
> + The packet was not recognized.

Same here.

> + A successful reply from the stub and indicates that the stub has found
                                     ^^^
That "and" seems extraneous.

Other than that, this can go in.  Thanks again for working on this.


  reply	other threads:[~2005-11-19 22:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-20 13:12 Jim Blandy
2005-11-20 14:57 ` Eli Zaretskii [this message]
2005-11-20 16:08   ` Jim Blandy
2005-11-20 19:27     ` Jim Blandy
2005-11-21  4:47     ` Eli Zaretskii
2005-11-21  4:52       ` Jim Blandy
2005-11-21  7:29         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=uk6f4fe2f.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jimb@red-bean.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox