Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@red-bean.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: GDB manual: document tracepoint packets
Date: Sun, 20 Nov 2005 16:08:00 -0000	[thread overview]
Message-ID: <8f2776cb0511192143h21c1d647yc766a09e1bcc3184@mail.gmail.com> (raw)
In-Reply-To: <uk6f4fe2f.fsf@gnu.org>

On 11/19/05, Eli Zaretskii <eliz@gnu.org> wrote:
> > + @node Tracepoint Packets
> > + @section Tracepoint Packets
>
> Suggest a @cindex entry here, something like "tracepoint packets".

D'oh.  Of course.

> > + Here we describe the packets @value{GDBN} uses to implement
> > + tracepoints (@pxref{Tracepoints}).
>
> I think it would be good to have an @xref from the "Tracepoints" node
> to here as well.

Added.

> > + Replies:
> > + @table @samp
> > + @item OK
> > + The packet was understood and carried out.
> > + @item
>
> Does this @item really need to be empty?  If so, why, and what do we
> want to appear here in print?

It does.  This appears as a pair of matched single quotes enclosing
nothing in both the Info and printable manuals.  The remote stub
returns an empty packet to indicate that it didn't understand the
command.  Blank @items are used elsewhere in the manual for this
purpose.

> > + A successful reply from the stub and indicates that the stub has found
>                                      ^^^
> That "and" seems extraneous.

It is.

> Other than that, this can go in.  Thanks again for working on this.

I'll commit it.  Thanks very much for your prompt review!


  reply	other threads:[~2005-11-20  5:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-20 13:12 Jim Blandy
2005-11-20 14:57 ` Eli Zaretskii
2005-11-20 16:08   ` Jim Blandy [this message]
2005-11-20 19:27     ` Jim Blandy
2005-11-21  4:47     ` Eli Zaretskii
2005-11-21  4:52       ` Jim Blandy
2005-11-21  7:29         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8f2776cb0511192143h21c1d647yc766a09e1bcc3184@mail.gmail.com \
    --to=jimb@red-bean.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox