[patch] ada-lang.c, probable typo

[patch] ada-lang.c, probable typo

[msnyder]

[-- Attachment #1: Type: text/plain, Size: 55 bytes --]

I'm sure this is what the author meant to type.   ;-)


[-- Attachment #2: 1.txt --]
[-- Type: text/plain, Size: 959 bytes --]

2007-08-04  Michael Snyder  <msnyder@access-company.com>

	* ada-lang.c (desc_bounds): Comparison of function address to NULL.

Index: ada-lang.c
===================================================================
RCS file: /cvs/src/src/gdb/ada-lang.c,v
retrieving revision 1.99
diff -p -r1.99 ada-lang.c
*** ada-lang.c	13 Jun 2007 17:11:09 -0000	1.99
--- ada-lang.c	5 Aug 2007 04:10:50 -0000
*************** desc_bounds (struct value *arr)
*** 1322,1328 ****
          desc_bounds_type (thin_descriptor_type (type));
        LONGEST addr;
  
!       if (desc_bounds_type == NULL)
          error (_("Bad GNAT array descriptor"));
  
        /* NOTE: The following calculation is not really kosher, but
--- 1322,1328 ----
          desc_bounds_type (thin_descriptor_type (type));
        LONGEST addr;
  
!       if (bounds_type == NULL)
          error (_("Bad GNAT array descriptor"));
  
        /* NOTE: The following calculation is not really kosher, but

Re: [patch] ada-lang.c, probable typo

[Joel Brobecker]

> I'm sure this is what the author meant to type.   ;-)

> 2007-08-04  Michael Snyder  <msnyder@access-company.com>
> 
> 	* ada-lang.c (desc_bounds): Comparison of function address to NULL.

Correct! We never tripped on this because the compiler would have to
generate incorrect debugging info for this to happen. We checked in
this fix in our tree and I think you should check it in too (but I don't
have approval priviledges).

Thanks!

-- 
Joel

Re: [patch] ada-lang.c, probable typo

[Daniel Jacobowitz]

On Sun, Aug 05, 2007 at 09:59:58PM -0700, Joel Brobecker wrote:
> > I'm sure this is what the author meant to type.   ;-)
> 
> > 2007-08-04  Michael Snyder  <msnyder@access-company.com>
> > 
> > 	* ada-lang.c (desc_bounds): Comparison of function address to NULL.
> 
> Correct! We never tripped on this because the compiler would have to
> generate incorrect debugging info for this to happen. We checked in
> this fix in our tree and I think you should check it in too (but I don't
> have approval priviledges).

Why on earth don't you?

Does anyone (including Joel, you get a chance to object when I
nominate you for more work) object to making Joel the maintainer of
Ada support in GDB?

-- 
Daniel Jacobowitz
CodeSourcery

Re: [patch] ada-lang.c, probable typo

[Eli Zaretskii]

> Date: Mon, 6 Aug 2007 07:09:13 -0400
> From: Daniel Jacobowitz <drow@false.org>
> Cc: msnyder@sonic.net, gdb-patches@sourceware.org
> 
> On Sun, Aug 05, 2007 at 09:59:58PM -0700, Joel Brobecker wrote:
> > I don't have approval priviledges.
> 
> Why on earth don't you?
> 
> Does anyone (including Joel, you get a chance to object when I
> nominate you for more work) object to making Joel the maintainer of
> Ada support in GDB?

It makes perfect sense to me to have Joel as Ada support maintainer.

I'm bewildered how did we fail to do that until now.

Re: [patch] ada-lang.c, probable typo

[msnyder]

>> Date: Mon, 6 Aug 2007 07:09:13 -0400
>> From: Daniel Jacobowitz <drow@false.org>
>> Cc: msnyder@sonic.net, gdb-patches@sourceware.org
>>
>> On Sun, Aug 05, 2007 at 09:59:58PM -0700, Joel Brobecker wrote:
>> > I don't have approval priviledges.
>>
>> Why on earth don't you?
>>
>> Does anyone (including Joel, you get a chance to object when I
>> nominate you for more work) object to making Joel the maintainer of
>> Ada support in GDB?
>
> It makes perfect sense to me to have Joel as Ada support maintainer.
>
> I'm bewildered how did we fail to do that until now.

I had the same thought.

Re: [patch] ada-lang.c, probable typo

[Joel Brobecker]

> Does anyone (including Joel, you get a chance to object when I
> nominate you for more work) object to making Joel the maintainer of
> Ada support in GDB?

No objection from me :). I was already committed to help maintaining
this file anyway.

-- 
Joel

Re: [patch] ada-lang.c, probable typo

[msnyder]

>> I'm sure this is what the author meant to type.   ;-)
>
>> 2007-08-04  Michael Snyder  <msnyder@access-company.com>
>>
>> 	* ada-lang.c (desc_bounds): Comparison of function address to NULL.
>
> Correct! We never tripped on this because the compiler would have to
> generate incorrect debugging info for this to happen. We checked in
> this fix in our tree and I think you should check it in too (but I don't
> have approval priviledges).

The heck with that -- I'm taking this as approval!

Committed.   ;-)