From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2206 invoked by alias); 6 Aug 2007 11:09:22 -0000 Received: (qmail 2137 invoked by uid 22791); 6 Aug 2007 11:09:20 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 06 Aug 2007 11:09:18 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id D60F8982C5; Mon, 6 Aug 2007 11:09:17 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 217AB982AD; Mon, 6 Aug 2007 11:09:16 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1II0SX-00067O-Et; Mon, 06 Aug 2007 07:09:13 -0400 Date: Mon, 06 Aug 2007 11:09:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: msnyder@sonic.net, gdb-patches@sourceware.org Subject: Re: [patch] ada-lang.c, probable typo Message-ID: <20070806110913.GA23238@caradoc.them.org> Mail-Followup-To: Joel Brobecker , msnyder@sonic.net, gdb-patches@sourceware.org References: <23704.12.7.175.2.1186287201.squirrel@webmail.sonic.net> <20070806045958.GC11351@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070806045958.GC11351@adacore.com> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00117.txt.bz2 On Sun, Aug 05, 2007 at 09:59:58PM -0700, Joel Brobecker wrote: > > I'm sure this is what the author meant to type. ;-) > > > 2007-08-04 Michael Snyder > > > > * ada-lang.c (desc_bounds): Comparison of function address to NULL. > > Correct! We never tripped on this because the compiler would have to > generate incorrect debugging info for this to happen. We checked in > this fix in our tree and I think you should check it in too (but I don't > have approval priviledges). Why on earth don't you? Does anyone (including Joel, you get a chance to object when I nominate you for more work) object to making Joel the maintainer of Ada support in GDB? -- Daniel Jacobowitz CodeSourcery