PR/2386 [1/2]: MinGW attach to process without an exec file

PR/2386 [1/2]: MinGW attach to process without an exec file

[Pedro Alves]

[-- Attachment #1: Type: text/plain, Size: 653 bytes --]

We currently don't set a default gdb_osabi for MinGW, Cygwin or WinCE,

Having a default osabi allows gdb to set a useful current_gdbarch
if for some reason gdb isn't able to open a bfd to the executable.

For multi-target builds, the default will probably not make sense
for any other target than the native -- so we may want to
move this default osabi somewhere else, like the target interface, or
moving the target string matching into runtime code, but that's
for another day.  The patch just follows status quo.

Tested on XP Pro SP2, i686-pc-cygwin.  There is a regression,
because now Cygwin will also trip on gdb/2225.

OK ?

-- 
Pedro Alves




[-- Attachment #2: win32_default_osabi.diff --]
[-- Type: text/x-diff, Size: 818 bytes --]

2007-12-28  Pedro Alves  <pedro_alves@portugalmail.pt>

	* configure.tgt (*-*-mingw32ce*): Set gdb_osabi to
	GDB_OSABI_WINCE.
	(*-*-mingw* | *-*-cygwin*): Set gdb_osabi to GDB_OSABI_CYGWIN.

---
 gdb/configure.tgt |    3 +++
 1 file changed, 3 insertions(+)

Index: src/gdb/configure.tgt
===================================================================
--- src.orig/gdb/configure.tgt	2007-12-26 23:46:34.000000000 +0000
+++ src/gdb/configure.tgt	2007-12-27 00:50:52.000000000 +0000
@@ -530,4 +530,7 @@ m68*-*-openbsd* | m88*-*-openbsd* | vax-
 *-*-solaris*)	gdb_osabi=GDB_OSABI_SOLARIS ;;
 *-*-*-gnu*)	;; # prevent non-GNU kernels to match the Hurd rule below
 *-*-gnu*)	gdb_osabi=GDB_OSABI_HURD ;;
+*-*-mingw32ce*)	gdb_osabi=GDB_OSABI_WINCE ;;
+*-*-mingw* | *-*-cygwin*)
+		gdb_osabi=GDB_OSABI_CYGWIN ;;
 esac

Re: PR/2386 [1/2]: MinGW attach to process without an exec file

[Eli Zaretskii]

> Date: Fri, 28 Dec 2007 01:20:57 +0000
> From: Pedro Alves <pedro_alves@portugalmail.pt>
> CC: Bogdan Slusarczyk <bodzio131@op.pl>
> 
> 	(*-*-mingw* | *-*-cygwin*): Set gdb_osabi to GDB_OSABI_CYGWIN.

Is this really right?  Unless I'm missing something, GDB_OSABI_CYGWIN
is not the native Windows ABI, is it?

Re: PR/2386 [1/2]: MinGW attach to process without an exec file

[Pedro Alves]

Eli Zaretskii wrote:
>> Date: Fri, 28 Dec 2007 01:20:57 +0000
>> From: Pedro Alves <pedro_alves@portugalmail.pt>
>> CC: Bogdan Slusarczyk <bodzio131@op.pl>
>>
>> 	(*-*-mingw* | *-*-cygwin*): Set gdb_osabi to GDB_OSABI_CYGWIN.
> 
> Is this really right?  Unless I'm missing something, GDB_OSABI_CYGWIN
> is not the native Windows ABI, is it?
> 

There is no Cygwin ABI, to the best of my knowledge, since Cygwin is a
library that sits on top of Windows, it follows the Windows ABI.  When
MinGW support was introduced, I didn't rename that.  I haven't found a
reason to split Cygwin|MinGW at this level.  I was avoiding rename-only
patches, in a rename-as-I-touch mode.

-- 
Pedro Alves

Re: PR/2386 [1/2]: MinGW attach to process without an exec file

[Eli Zaretskii]

> Date: Sat, 29 Dec 2007 14:35:18 +0000
> From: Pedro Alves <pedro_alves@portugalmail.pt>
> CC: gdb-patches@sourceware.org, bodzio131@op.pl
> 
> Eli Zaretskii wrote:
> >> Date: Fri, 28 Dec 2007 01:20:57 +0000
> >> From: Pedro Alves <pedro_alves@portugalmail.pt>
> >> CC: Bogdan Slusarczyk <bodzio131@op.pl>
> >>
> >> 	(*-*-mingw* | *-*-cygwin*): Set gdb_osabi to GDB_OSABI_CYGWIN.
> > 
> > Is this really right?  Unless I'm missing something, GDB_OSABI_CYGWIN
> > is not the native Windows ABI, is it?
> > 
> 
> There is no Cygwin ABI, to the best of my knowledge, since Cygwin is a
> library that sits on top of Windows, it follows the Windows ABI.  When
> MinGW support was introduced, I didn't rename that.  I haven't found a
> reason to split Cygwin|MinGW at this level.  I was avoiding rename-only
> patches, in a rename-as-I-touch mode.

Thanks for explanations.

Re: PR/2386 [1/2]: MinGW attach to process without an exec file

[Daniel Jacobowitz]

On Fri, Dec 28, 2007 at 01:20:57AM +0000, Pedro Alves wrote:
> 2007-12-28  Pedro Alves  <pedro_alves@portugalmail.pt>
> 
> 	* configure.tgt (*-*-mingw32ce*): Set gdb_osabi to
> 	GDB_OSABI_WINCE.
> 	(*-*-mingw* | *-*-cygwin*): Set gdb_osabi to GDB_OSABI_CYGWIN.

This is OK.

-- 
Daniel Jacobowitz
CodeSourcery