Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Denis PILAT <denis.pilat@st.com>
Cc: gdb-patches@sources.redhat.com, bash-maintainers@gnu.org
Subject: Re: [patch-readline] history file generation on minGW host
Date: Fri, 17 Mar 2006 16:07:00 -0000	[thread overview]
Message-ID: <uirqdpd2r.fsf@gnu.org> (raw)
In-Reply-To: <44196BC6.4050503@st.com> (message from Denis PILAT on Thu, 16 	Mar 2006 14:44:38 +0100)

> Date: Thu, 16 Mar 2006 14:44:38 +0100
> From: Denis PILAT <denis.pilat@st.com>
> 
> On minGW host, history file are open in text mode, that's imply windows 
> specific
> carriage return to be inserted ( \n -> \r\n conversion performed) and 
> prevents windows history file to be compliant with linux one's.
> When using current history file for windows, "^M" appears at each end of 
> line.
> 
> This patch fixes this problem.

Thanks.

However, I think there's a better fix: teach readline to always remove
any CRs before an LF character, even on Posix platforms.  That way,
even if the history file was edited by some Windows editor that
doesn't honor the end-of-line format, it can still be read on any OS.
And as a bonus, we might get a cleaner code, without ugly OS-dependent
#ifdef's.

Unless Chet and others disagree, would you like to prepare a patch
along these lines?


  parent reply	other threads:[~2006-03-17 10:42 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-17  0:15 Denis PILAT
2006-03-17  0:26 ` Daniel Jacobowitz
2006-03-17  0:31   ` Denis PILAT
2006-03-17 16:07 ` Eli Zaretskii [this message]
2006-03-17 19:12   ` Denis PILAT
2006-03-17 19:37     ` Chet Ramey
2006-03-21 15:30   ` [patch-readline] history file reading Denis PILAT
2006-03-21 15:32     ` Chet Ramey
2006-03-21 15:38       ` Daniel Jacobowitz
2006-03-21 16:29         ` Andreas Schwab
2006-03-21 16:42           ` Bob Rossi
2006-03-21 16:46             ` Daniel Jacobowitz
2006-03-23  4:55             ` Eli Zaretskii
2006-03-21 19:52         ` Brian J. Fox
2006-03-21 19:55           ` Daniel Jacobowitz
2006-03-21 20:02           ` Andreas Schwab
2006-03-23  5:15             ` Eli Zaretskii
2006-03-23  4:37         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=uirqdpd2r.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=bash-maintainers@gnu.org \
    --cc=denis.pilat@st.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox