From: Andreas Schwab <schwab@suse.de>
To: Denis PILAT <denis.pilat@st.com>
Cc: Chet Ramey <chet.ramey@case.edu>, Eli Zaretskii <eliz@gnu.org>,
gdb-patches@sources.redhat.com, bash-maintainers@gnu.org
Subject: Re: [patch-readline] history file reading
Date: Tue, 21 Mar 2006 16:29:00 -0000 [thread overview]
Message-ID: <jeodzzhl30.fsf@sykes.suse.de> (raw)
In-Reply-To: <20060321145842.GA25689@nevyn.them.org> (Daniel Jacobowitz's message of "Tue, 21 Mar 2006 09:58:42 -0500")
Daniel Jacobowitz <drow@false.org> writes:
>> + if ( line_end - 1 >= line_start && *( line_end - 1 ) =='\r' )
>> + *( line_end - 1 ) = '\0';
>
> And you don't need the spaces inside the parentheses, but do usually
> need spaces around operators:
>
> if (line_end - 1 >= line_start && *(line_end - 1) == '\r')
> *(line_end - 1) = '\0';
line_end[-1] whould be much better readable, IMHO.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2006-03-21 15:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-17 0:15 [patch-readline] history file generation on minGW host Denis PILAT
2006-03-17 0:26 ` Daniel Jacobowitz
2006-03-17 0:31 ` Denis PILAT
2006-03-17 16:07 ` Eli Zaretskii
2006-03-17 19:12 ` Denis PILAT
2006-03-17 19:37 ` Chet Ramey
2006-03-21 15:30 ` [patch-readline] history file reading Denis PILAT
2006-03-21 15:32 ` Chet Ramey
2006-03-21 15:38 ` Daniel Jacobowitz
2006-03-21 16:29 ` Andreas Schwab [this message]
2006-03-21 16:42 ` Bob Rossi
2006-03-21 16:46 ` Daniel Jacobowitz
2006-03-23 4:55 ` Eli Zaretskii
2006-03-21 19:52 ` Brian J. Fox
2006-03-21 19:55 ` Daniel Jacobowitz
2006-03-21 20:02 ` Andreas Schwab
2006-03-23 5:15 ` Eli Zaretskii
2006-03-23 4:37 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jeodzzhl30.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=bash-maintainers@gnu.org \
--cc=chet.ramey@case.edu \
--cc=denis.pilat@st.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox