Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Denis PILAT <denis.pilat@st.com>
To: gdb-patches@sources.redhat.com
Subject: [patch-readline] history file generation on minGW host
Date: Fri, 17 Mar 2006 00:15:00 -0000	[thread overview]
Message-ID: <44196BC6.4050503@st.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 341 bytes --]

On minGW host, history file are open in text mode, that's imply windows 
specific
carriage return to be inserted ( \n -> \r\n conversion performed) and 
prevents windows history file to be compliant with linux one's.
When using current history file for windows, "^M" appears at each end of 
line.

This patch fixes this problem.
-- 
Denis



[-- Attachment #2: readline.patch --]
[-- Type: text/plain, Size: 1095 bytes --]

Index: readline/histfile.c
===================================================================
--- readline/histfile.c	(revision 368)
+++ readline/histfile.c	(working copy)
@@ -70,17 +70,18 @@
 #endif /* HAVE_MMAP */
 
 /* If we're compiling for __EMX__ (OS/2) or __CYGWIN__ (cygwin32 environment
-   on win 95/98/nt), we want to open files with O_BINARY mode so that there
+   on win 95/98/nt) or __MINGW32__ (pure windows environment),
+   we want to open files with O_BINARY mode so that there
    is no \n -> \r\n conversion performed.  On other systems, we don't want to
    mess around with O_BINARY at all, so we ensure that it's defined to 0. */
-#if defined (__EMX__) || defined (__CYGWIN__)
+#if defined (__EMX__) || defined (__CYGWIN__) || defined (__MINGW32__)
 #  ifndef O_BINARY
 #    define O_BINARY 0
 #  endif
-#else /* !__EMX__ && !__CYGWIN__ */
+#else /* !__EMX__ && !__CYGWIN__ && !__MINGW32__ */ 
 #  undef O_BINARY
 #  define O_BINARY 0
-#endif /* !__EMX__ && !__CYGWIN__ */
+#endif /* !__EMX__ && !__CYGWIN__ && !__MINGW32__ */
 
 #include <errno.h>
 #if !defined (errno)

[-- Attachment #3: ChangeLog.gdb --]
[-- Type: text/plain, Size: 118 bytes --]

2006-03-16  Denis Pilat <denis.pilat@st.com>

	* histfile.c (O_BINARY): Avoid \n -> \r\n conversion 
	for minGW host.

             reply	other threads:[~2006-03-16 13:44 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-17  0:15 Denis PILAT [this message]
2006-03-17  0:26 ` Daniel Jacobowitz
2006-03-17  0:31   ` Denis PILAT
2006-03-17 16:07 ` Eli Zaretskii
2006-03-17 19:12   ` Denis PILAT
2006-03-17 19:37     ` Chet Ramey
2006-03-21 15:30   ` [patch-readline] history file reading Denis PILAT
2006-03-21 15:32     ` Chet Ramey
2006-03-21 15:38       ` Daniel Jacobowitz
2006-03-21 16:29         ` Andreas Schwab
2006-03-21 16:42           ` Bob Rossi
2006-03-21 16:46             ` Daniel Jacobowitz
2006-03-23  4:55             ` Eli Zaretskii
2006-03-21 19:52         ` Brian J. Fox
2006-03-21 19:55           ` Daniel Jacobowitz
2006-03-21 20:02           ` Andreas Schwab
2006-03-23  5:15             ` Eli Zaretskii
2006-03-23  4:37         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44196BC6.4050503@st.com \
    --to=denis.pilat@st.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox