Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Vladimir Prus <ghost@cs.msu.su>
Cc: gdb-patches@sources.redhat.com
Subject: Re: "target remote | " stderr
Date: Sun, 11 Feb 2007 20:24:00 -0000	[thread overview]
Message-ID: <uire85tq7.fsf@gnu.org> (raw)
In-Reply-To: <eqnhq8$8nt$1@sea.gmane.org> (message from Vladimir Prus on Sun, 	11 Feb 2007 19:55:03 +0300)

> From:  Vladimir Prus <ghost@cs.msu.su>
> Date:  Sun, 11 Feb 2007 19:55:03 +0300
>
> --- gdb/serial.h	(/mirrors/gdb_mainline)	(revision 3417)
> +++ gdb/serial.h	(/patches/gdb/remote_stderr_try2/gdb_mainline)	(revision 3417)
> @@ -191,6 +191,12 @@ extern int serial_debug_p (struct serial
>  struct serial
>    {
>      int fd;			/* File descriptor */
> +    int error_fd;               /* File descriptor for a separate
> +				   error stream that should be
> +				   immediately forwarded to gdb_stderr.
> +				   This may be -1.  
> +				   If != -1, this descriptor should
> +				   be non-blocking.  */

This comment isn't according to GNU coding standards, I think.

> +#ifdef _WIN32

Won't this catch Cygwin as well?  Do we want that?

Thanks.


  parent reply	other threads:[~2007-02-11 20:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-26 13:54 Vladimir Prus
2007-01-26 14:00 ` Daniel Jacobowitz
2007-01-31 14:35   ` Vladimir Prus
2007-01-31 14:41     ` Daniel Jacobowitz
2007-02-11 16:56       ` Vladimir Prus
2007-02-11 18:10         ` Mark Kettenis
2007-02-17  7:50           ` Vladimir Prus
2007-02-11 20:24         ` Eli Zaretskii [this message]
2007-02-17  7:35           ` Vladimir Prus
2007-02-17 10:56             ` Eli Zaretskii
2007-02-17 14:31               ` Vladimir Prus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=uire85tq7.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=ghost@cs.msu.su \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox