From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-47637-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 19284 invoked by alias); 11 Feb 2007 20:24:14 -0000
Received: (qmail 19268 invoked by uid 22791); 11 Feb 2007 20:24:13 -0000
X-Spam-Check-By: sourceware.org
Received: from nitzan.inter.net.il (HELO nitzan.inter.net.il) (213.8.233.22)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 11 Feb 2007 20:24:07 +0000
Received: from HOME-C4E4A596F7 (IGLD-84-228-248-86.inter.net.il [84.228.248.86]) 	by nitzan.inter.net.il (MOS 3.7.3a-GA) 	with ESMTP id GAJ86368 (AUTH halo1); 	Sun, 11 Feb 2007 22:23:18 +0200 (IST)
Date: Sun, 11 Feb 2007 20:24:00 -0000
Message-Id: <uire85tq7.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Vladimir Prus <ghost@cs.msu.su>
CC: gdb-patches@sources.redhat.com
In-reply-to: <eqnhq8$8nt$1@sea.gmane.org> (message from Vladimir Prus on Sun, 	11 Feb 2007 19:55:03 +0300)
Subject: Re: "target remote | " stderr
Reply-to: Eli Zaretskii <eliz@gnu.org>
References: <200701261653.53834.vladimir@codesourcery.com> <20070126140028.GA29456@nevyn.them.org> <epq9dd$k4s$1@sea.gmane.org> <20070131144101.GA23780@nevyn.them.org> <eqnhq8$8nt$1@sea.gmane.org>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-02/txt/msg00157.txt.bz2

> From:  Vladimir Prus <ghost@cs.msu.su>
> Date:  Sun, 11 Feb 2007 19:55:03 +0300
>
> --- gdb/serial.h	(/mirrors/gdb_mainline)	(revision 3417)
> +++ gdb/serial.h	(/patches/gdb/remote_stderr_try2/gdb_mainline)	(revision 3417)
> @@ -191,6 +191,12 @@ extern int serial_debug_p (struct serial
>  struct serial
>    {
>      int fd;			/* File descriptor */
> +    int error_fd;               /* File descriptor for a separate
> +				   error stream that should be
> +				   immediately forwarded to gdb_stderr.
> +				   This may be -1.  
> +				   If != -1, this descriptor should
> +				   be non-blocking.  */

This comment isn't according to GNU coding standards, I think.

> +#ifdef _WIN32

Won't this catch Cygwin as well?  Do we want that?

Thanks.