Re: "target remote | " stderr

[Eli Zaretskii <eliz@gnu.org>]

> From: Vladimir Prus <ghost@cs.msu.su>
> Date: Sat, 17 Feb 2007 10:34:36 +0300
> 
> >> +    int error_fd;               /* File descriptor for a separate
> >> +                               error stream that should be
> >> +                               immediately forwarded to gdb_stderr.
> >> +                               This may be -1.
> >> +                               If != -1, this descriptor should
> >> +                               be non-blocking.  */
> > 
> > This comment isn't according to GNU coding standards, I think.
> 
> Can you please be more specific?

Not sure what you want me to say.  Multiline, multiple-sentence
comments should not be alongside of the code, they should precede the
code.  Example:

    /* File descriptor for a separate error stream that should be
       immediately forwarded to gdb_stderr.  This may be -1.
       If != -1, this descriptor should be non-blocking.  */
    int error_fd;

> >> +#ifdef _WIN32
> > 
> > Won't this catch Cygwin as well?  Do we want that?
> 
> I would hope this won't catch cygwin, but I don't know. I'll check.

Thanks.