From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-47696-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 28547 invoked by alias); 17 Feb 2007 10:56:23 -0000
Received: (qmail 28535 invoked by uid 22791); 17 Feb 2007 10:56:23 -0000
X-Spam-Check-By: sourceware.org
Received: from romy.inter.net.il (HELO romy.inter.net.il) (213.8.233.24)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 17 Feb 2007 10:56:18 +0000
Received: from HOME-C4E4A596F7 ([81.5.50.212]) 	by romy.inter.net.il (MOS 3.7.3-GA) 	with ESMTP id HDG24337 (AUTH halo1); 	Sat, 17 Feb 2007 12:56:07 +0200 (IST)
Date: Sat, 17 Feb 2007 10:56:00 -0000
Message-Id: <ubqjtkq7r.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Vladimir Prus <ghost@cs.msu.su>
CC: gdb-patches@sources.redhat.com
In-reply-to: <E1HIK6J-000273-D7@zigzag.lvk.cs.msu.su> (message from Vladimir 	Prus on Sat, 17 Feb 2007 10:34:36 +0300)
Subject: Re: "target remote | " stderr
Reply-to: Eli Zaretskii <eliz@gnu.org>
References: <200701261653.53834.vladimir@codesourcery.com> <20070126140028.GA29456@nevyn.them.org> <epq9dd$k4s$1@sea.gmane.org> <20070131144101.GA23780@nevyn.them.org> <eqnhq8$8nt$1@sea.gmane.org> <uire85tq7.fsf@gnu.org> <E1HIK6J-000273-D7@zigzag.lvk.cs.msu.su>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-02/txt/msg00216.txt.bz2

> From: Vladimir Prus <ghost@cs.msu.su>
> Date: Sat, 17 Feb 2007 10:34:36 +0300
> 
> >> +    int error_fd;               /* File descriptor for a separate
> >> +                               error stream that should be
> >> +                               immediately forwarded to gdb_stderr.
> >> +                               This may be -1.
> >> +                               If != -1, this descriptor should
> >> +                               be non-blocking.  */
> > 
> > This comment isn't according to GNU coding standards, I think.
> 
> Can you please be more specific?

Not sure what you want me to say.  Multiline, multiple-sentence
comments should not be alongside of the code, they should precede the
code.  Example:

    /* File descriptor for a separate error stream that should be
       immediately forwarded to gdb_stderr.  This may be -1.
       If != -1, this descriptor should be non-blocking.  */
    int error_fd;

> >> +#ifdef _WIN32
> > 
> > Won't this catch Cygwin as well?  Do we want that?
> 
> I would hope this won't catch cygwin, but I don't know. I'll check.

Thanks.