From: Eli Zaretskii <eliz@gnu.org>
To: teawater <teawater@gmail.com>
Cc: msnyder@vmware.com, gdb-patches@sourceware.org
Subject: Re: [reverse RFA] Remove process record warning code
Date: Fri, 17 Oct 2008 10:58:00 -0000 [thread overview]
Message-ID: <uej2fmqu2.fsf@gnu.org> (raw)
In-Reply-To: <daef60380810170057l56803830nf79e6d6befa7f3cc@mail.gmail.com>
> Date: Fri, 17 Oct 2008 15:57:03 +0800
> From: teawater <teawater@gmail.com>
>
> @@ -427,12 +426,8 @@ kill_if_already_running (int from_tty)
> restart it. */
> target_require_runnable ();
>
> - if (from_tty)
> - if (!query (RECORD_IS_USED ?
> - "The program being debugged has been started already,\n\
> -and is running in record/replay mode. Do you want to abandon\n\
> -the recording and start the program from the beginning? " :
> - "The program being debugged has been started already.\n\
> + if (from_tty
> + && !query ("The program being debugged has been started already.\n\
> Start it from the beginning? "))
> error (_("Program not restarted."));
> target_kill ();
Should the string in the call to `query' be in _() ? (Yes, I know you
just copied existing code, but why not fix it while at that?)
next prev parent reply other threads:[~2008-10-17 10:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-17 7:57 teawater
2008-10-17 10:58 ` Eli Zaretskii [this message]
2008-10-17 15:01 ` teawater
2008-10-17 17:28 ` Michael Snyder
2008-10-18 1:35 ` teawater
2008-10-18 1:58 ` Michael Snyder
2008-10-18 2:20 ` teawater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uej2fmqu2.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox