From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32099 invoked by alias); 17 Oct 2008 10:58:28 -0000 Received: (qmail 32091 invoked by uid 22791); 17 Oct 2008 10:58:27 -0000 X-Spam-Check-By: sourceware.org Received: from mtaout2.012.net.il (HELO mtaout2.012.net.il) (84.95.2.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 17 Oct 2008 10:57:44 +0000 Received: from HOME-C4E4A596F7 ([77.127.24.3]) by i_mtaout2.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0K8V00KL9QIH12S2@i_mtaout2.012.net.il> for gdb-patches@sourceware.org; Fri, 17 Oct 2008 12:59:06 +0200 (IST) Date: Fri, 17 Oct 2008 10:58:00 -0000 From: Eli Zaretskii Subject: Re: [reverse RFA] Remove process record warning code In-reply-to: X-012-Sender: halo1@inter.net.il To: teawater Cc: msnyder@vmware.com, gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: References: X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00427.txt.bz2 > Date: Fri, 17 Oct 2008 15:57:03 +0800 > From: teawater > > @@ -427,12 +426,8 @@ kill_if_already_running (int from_tty) > restart it. */ > target_require_runnable (); > > - if (from_tty) > - if (!query (RECORD_IS_USED ? > - "The program being debugged has been started already,\n\ > -and is running in record/replay mode. Do you want to abandon\n\ > -the recording and start the program from the beginning? " : > - "The program being debugged has been started already.\n\ > + if (from_tty > + && !query ("The program being debugged has been started already.\n\ > Start it from the beginning? ")) > error (_("Program not restarted.")); > target_kill (); Should the string in the call to `query' be in _() ? (Yes, I know you just copied existing code, but why not fix it while at that?)