From: teawater <teawater@gmail.com>
To: "Eli Zaretskii" <eliz@gnu.org>
Cc: msnyder@vmware.com, gdb-patches@sourceware.org
Subject: Re: [reverse RFA] Remove process record warning code
Date: Fri, 17 Oct 2008 15:01:00 -0000 [thread overview]
Message-ID: <daef60380810170801j4000f42bo520480d510579772@mail.gmail.com> (raw)
In-Reply-To: <uej2fmqu2.fsf@gnu.org>
It just for the reverse-20080930-branch. This remove just mean that we
don't need this code.
BTW There are a lot query don't have _(. Maybe you can make a patch for them.
On Fri, Oct 17, 2008 at 18:57, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Fri, 17 Oct 2008 15:57:03 +0800
>> From: teawater <teawater@gmail.com>
>>
>> @@ -427,12 +426,8 @@ kill_if_already_running (int from_tty)
>> restart it. */
>> target_require_runnable ();
>>
>> - if (from_tty)
>> - if (!query (RECORD_IS_USED ?
>> - "The program being debugged has been started already,\n\
>> -and is running in record/replay mode. Do you want to abandon\n\
>> -the recording and start the program from the beginning? " :
>> - "The program being debugged has been started already.\n\
>> + if (from_tty
>> + && !query ("The program being debugged has been started already.\n\
>> Start it from the beginning? "))
>> error (_("Program not restarted."));
>> target_kill ();
>
> Should the string in the call to `query' be in _() ? (Yes, I know you
> just copied existing code, but why not fix it while at that?)
>
next prev parent reply other threads:[~2008-10-17 15:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-17 7:57 teawater
2008-10-17 10:58 ` Eli Zaretskii
2008-10-17 15:01 ` teawater [this message]
2008-10-17 17:28 ` Michael Snyder
2008-10-18 1:35 ` teawater
2008-10-18 1:58 ` Michael Snyder
2008-10-18 2:20 ` teawater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=daef60380810170801j4000f42bo520480d510579772@mail.gmail.com \
--to=teawater@gmail.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox