From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-59315-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 14663 invoked by alias); 17 Oct 2008 15:01:41 -0000
Received: (qmail 14651 invoked by uid 22791); 17 Oct 2008 15:01:40 -0000
X-Spam-Check-By: sourceware.org
Received: from ti-out-0910.google.com (HELO ti-out-0910.google.com) (209.85.142.186)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 17 Oct 2008 15:01:05 +0000
Received: by ti-out-0910.google.com with SMTP id d10so349656tib.12         for <gdb-patches@sourceware.org>; Fri, 17 Oct 2008 08:01:01 -0700 (PDT)
Received: by 10.110.37.17 with SMTP id k17mr1544008tik.6.1224255661272;         Fri, 17 Oct 2008 08:01:01 -0700 (PDT)
Received: by 10.110.42.9 with HTTP; Fri, 17 Oct 2008 08:01:01 -0700 (PDT)
Message-ID: <daef60380810170801j4000f42bo520480d510579772@mail.gmail.com>
Date: Fri, 17 Oct 2008 15:01:00 -0000
From: teawater <teawater@gmail.com>
To: "Eli Zaretskii" <eliz@gnu.org>
Subject: Re: [reverse RFA] Remove process record warning code
Cc: msnyder@vmware.com, gdb-patches@sourceware.org
In-Reply-To: <uej2fmqu2.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <daef60380810170057l56803830nf79e6d6befa7f3cc@mail.gmail.com> 	 <uej2fmqu2.fsf@gnu.org>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-10/txt/msg00431.txt.bz2

It just for the reverse-20080930-branch. This remove just mean that we
don't need this code.

BTW There are a lot query don't have _(. Maybe you can make a patch for them.

On Fri, Oct 17, 2008 at 18:57, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Fri, 17 Oct 2008 15:57:03 +0800
>> From: teawater <teawater@gmail.com>
>>
>> @@ -427,12 +426,8 @@ kill_if_already_running (int from_tty)
>>        restart it.  */
>>        target_require_runnable ();
>>
>> -      if (from_tty)
>> -     if (!query (RECORD_IS_USED ?
>> -                 "The program being debugged has been started already,\n\
>> -and is running in record/replay mode.  Do you want to abandon\n\
>> -the recording and start the program from the beginning? " :
>> -                 "The program being debugged has been started already.\n\
>> +      if (from_tty
>> +       && !query ("The program being debugged has been started already.\n\
>>  Start it from the beginning? "))
>>         error (_("Program not restarted."));
>>        target_kill ();
>
> Should the string in the call to `query' be in _() ?  (Yes, I know you
> just copied existing code, but why not fix it while at that?)
>