Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: gdb-patches@sourceware.org
Subject: Re: [RFA] win32-nat.c: Simplify generation of Windows environment
Date: Fri, 08 Dec 2006 11:31:00 -0000	[thread overview]
Message-ID: <ubqmevd3r.fsf@gnu.org> (raw)
In-Reply-To: <20061208091241.GC9829@calimero.vinschen.de> (message from 	Corinna Vinschen on Fri, 8 Dec 2006 10:12:41 +0100)

> Date: Fri, 8 Dec 2006 10:12:41 +0100
> From: Corinna Vinschen <vinschen@redhat.com>
> 
> How exactly are we supposed to think of and support code which is not
> part of the source tree when creating a patch?

You aren't required to think about it.  My request was just that---a
request, not an attempt to say that you made some grave mistake.

> As I just wrote in my reply to Jim, the cygwin_internal API is used in
> GDB for a long time, as a grep will show.  If win32-nat.c is used by
> some not-in-the-source-tree code somewere, it will already have to deal
> with cygwin_internal.  A patch for a native GDB will have created either
> a matching #define or a substitute for this function anyway.  I don't
> see how this new usage differs from the existing ones.

I really fail to understand the fuss that my simple request
generated.  All I asked for is 2 lines:

  #ifdef __CYGWIN__
  ...
  #endif


  reply	other threads:[~2006-12-08 11:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-07  9:58 Corinna Vinschen
2006-12-07 16:35 ` Corinna Vinschen
2006-12-07 19:48 ` Jim Blandy
2006-12-08  8:57   ` Corinna Vinschen
2006-12-07 21:37 ` Eli Zaretskii
2006-12-08  0:09   ` Jim Blandy
2006-12-08  7:31     ` Eli Zaretskii
2006-12-08  9:12       ` Corinna Vinschen
2006-12-08 11:31         ` Eli Zaretskii [this message]
2006-12-08 12:05           ` Corinna Vinschen
2006-12-09  8:01       ` Jim Blandy
2006-12-08 20:43   ` Christopher Faylor
2006-12-09  9:15     ` Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ubqmevd3r.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox