Re: [RFA] win32-nat.c: Simplify generation of Windows environment

[Corinna Vinschen <vinschen@redhat.com>]

On Dec  8 13:30, Eli Zaretskii wrote:
> > From: Corinna Vinschen
> > As I just wrote in my reply to Jim, the cygwin_internal API is used in
> > GDB for a long time, as a grep will show.  If win32-nat.c is used by
> > some not-in-the-source-tree code somewere, it will already have to deal
> > with cygwin_internal.  A patch for a native GDB will have created either
> > a matching #define or a substitute for this function anyway.  I don't
> > see how this new usage differs from the existing ones.
> 
> I really fail to understand the fuss that my simple request
> generated.  All I asked for is 2 lines:
> 
>   #ifdef __CYGWIN__
>   ...
>   #endif

All I say is, why setting a precedent at this point in the code,
when other places in the code are using cygwin_internal (or, fwiw,
cygwin_conv_to_posix_path, cygwin_conv_to_full_posix_path,
cygwin_conv_to_win32_path) without #ifdef/#endif bracket anyway.

There's also a pretty clear comment at the start of the file:

  /* We assume we're being built with and will be used for cygwin.  */


Corinna

-- 
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat