From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15070 invoked by alias); 8 Dec 2006 12:05:05 -0000 Received: (qmail 15058 invoked by uid 22791); 8 Dec 2006 12:05:04 -0000 X-Spam-Check-By: sourceware.org Received: from aquarius.hirmke.de (HELO calimero.vinschen.de) (217.91.18.234) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Fri, 08 Dec 2006 12:04:56 +0000 Received: by calimero.vinschen.de (Postfix, from userid 500) id EE05E544001; Fri, 8 Dec 2006 13:04:53 +0100 (CET) Date: Fri, 08 Dec 2006 12:05:00 -0000 From: Corinna Vinschen To: gdb-patches@sourceware.org Subject: Re: [RFA] win32-nat.c: Simplify generation of Windows environment Message-ID: <20061208120453.GD9829@calimero.vinschen.de> Reply-To: gdb-patches@sourceware.org Mail-Followup-To: gdb-patches@sourceware.org References: <20061207095839.GA14487@calimero.vinschen.de> <20061208091241.GC9829@calimero.vinschen.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.2i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-12/txt/msg00116.txt.bz2 On Dec 8 13:30, Eli Zaretskii wrote: > > From: Corinna Vinschen > > As I just wrote in my reply to Jim, the cygwin_internal API is used in > > GDB for a long time, as a grep will show. If win32-nat.c is used by > > some not-in-the-source-tree code somewere, it will already have to deal > > with cygwin_internal. A patch for a native GDB will have created either > > a matching #define or a substitute for this function anyway. I don't > > see how this new usage differs from the existing ones. > > I really fail to understand the fuss that my simple request > generated. All I asked for is 2 lines: > > #ifdef __CYGWIN__ > ... > #endif All I say is, why setting a precedent at this point in the code, when other places in the code are using cygwin_internal (or, fwiw, cygwin_conv_to_posix_path, cygwin_conv_to_full_posix_path, cygwin_conv_to_win32_path) without #ifdef/#endif bracket anyway. There's also a pretty clear comment at the start of the file: /* We assume we're being built with and will be used for cygwin. */ Corinna -- Corinna Vinschen Cygwin Project Co-Leader Red Hat