From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5940 invoked by alias); 8 Dec 2006 11:31:00 -0000 Received: (qmail 5923 invoked by uid 22791); 8 Dec 2006 11:30:57 -0000 X-Spam-Check-By: sourceware.org Received: from heller.inter.net.il (HELO heller.inter.net.il) (192.114.186.73) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 08 Dec 2006 11:30:46 +0000 Received: from HOME-C4E4A596F7 (IGLD-80-230-17-190.inter.net.il [80.230.17.190]) by heller.inter.net.il (MOS 3.7.3a-GA) with ESMTP id BFF81625 (AUTH halo1); Fri, 8 Dec 2006 13:30:42 +0200 (IST) Date: Fri, 08 Dec 2006 11:31:00 -0000 Message-Id: From: Eli Zaretskii To: gdb-patches@sourceware.org In-reply-to: <20061208091241.GC9829@calimero.vinschen.de> (message from Corinna Vinschen on Fri, 8 Dec 2006 10:12:41 +0100) Subject: Re: [RFA] win32-nat.c: Simplify generation of Windows environment Reply-to: Eli Zaretskii References: <20061207095839.GA14487@calimero.vinschen.de> <20061208091241.GC9829@calimero.vinschen.de> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-12/txt/msg00115.txt.bz2 > Date: Fri, 8 Dec 2006 10:12:41 +0100 > From: Corinna Vinschen > > How exactly are we supposed to think of and support code which is not > part of the source tree when creating a patch? You aren't required to think about it. My request was just that---a request, not an attempt to say that you made some grave mistake. > As I just wrote in my reply to Jim, the cygwin_internal API is used in > GDB for a long time, as a grep will show. If win32-nat.c is used by > some not-in-the-source-tree code somewere, it will already have to deal > with cygwin_internal. A patch for a native GDB will have created either > a matching #define or a substitute for this function anyway. I don't > see how this new usage differs from the existing ones. I really fail to understand the fuss that my simple request generated. All I asked for is 2 lines: #ifdef __CYGWIN__ ... #endif