Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Doug Evans" <dje@google.com>
Cc: msnyder@specifix.com, gdb-patches@sourceware.org
Subject: Re: [RFA] mixed source+assembly from cli disassemble
Date: Fri, 04 Apr 2008 09:58:00 -0000	[thread overview]
Message-ID: <u8wzut1gw.fsf@gnu.org> (raw)
In-Reply-To: <e394668d0804032025o7ae01cd8k142b4f54dbc565de@mail.gmail.com> 	(dje@google.com)

> Date: Thu, 3 Apr 2008 20:25:44 -0700
> From: "Doug Evans" <dje@google.com>
> Cc: gdb-patches@sourceware.org
> 
> Not well enough I'm afraid.  Messed up a comment (in front of
> disassemble_command).  Here's an improved version.

Thanks!

>    c = add_com ("disassemble", class_vars, disassemble_command, _("\
>  Disassemble a specified section of memory.\n\
>  Default is the function surrounding the pc of the selected frame.\n\
> +With a leading /s modifier source lines, if available, are included.\n\

Why do you say ``leading /s''?  What would /s be leading?

>  This specialized command dumps a range of memory as machine
> -instructions.  The default memory range is the function surrounding the
> +instructions.  It can also print mixed source+disassembly by specifying
> +the @code{/s} modifier.

An example would be good here, and the optional modifier should be
mentioned in the @item line above.

Other than that, the patch for gdb.texinfo is approved.  Thanks.


  reply	other threads:[~2008-04-04  9:27 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-04  3:26 Doug Evans
2008-04-04  9:17 ` Michael Snyder
2008-04-04  9:26   ` Doug Evans
2008-04-04  9:58     ` Eli Zaretskii [this message]
2008-04-09 22:27 ` Michael Snyder
2008-04-10 12:35   ` Joel Brobecker
2008-04-11  8:55     ` Michael Snyder
2008-04-15 20:32       ` Michael Snyder
2008-04-16 21:16 ` Joel Brobecker
2008-04-16 21:22   ` Doug Evans
2008-04-16 22:49   ` Doug Evans
2008-04-17 21:29     ` Joel Brobecker
2008-04-17 22:01       ` Daniel Jacobowitz
2008-04-17 22:45         ` Joel Brobecker
2008-04-28 18:52     ` Fwd: " Doug Evans
2008-04-29  0:54       ` Eli Zaretskii
2008-05-06  3:15         ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=u8wzut1gw.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=msnyder@specifix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox