From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25904 invoked by alias); 4 Apr 2008 09:27:05 -0000 Received: (qmail 25896 invoked by uid 22791); 4 Apr 2008 09:27:05 -0000 X-Spam-Check-By: sourceware.org Received: from heller.inter.net.il (HELO heller.inter.net.il) (213.8.233.23) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 04 Apr 2008 09:26:45 +0000 Received: from HOME-C4E4A596F7 (IGLD-84-229-231-225.inter.net.il [84.229.231.225]) by heller.inter.net.il (MOS 3.7.3a-GA) with ESMTP id FKR70022 (AUTH halo1); Fri, 4 Apr 2008 12:26:39 +0300 (IDT) Date: Fri, 04 Apr 2008 09:58:00 -0000 Message-Id: From: Eli Zaretskii To: "Doug Evans" CC: msnyder@specifix.com, gdb-patches@sourceware.org In-reply-to: (dje@google.com) Subject: Re: [RFA] mixed source+assembly from cli disassemble Reply-to: Eli Zaretskii References: <20080404003857.A5A451C72B9@localhost> <1207272481.31772.227.camel@localhost.localdomain> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00090.txt.bz2 > Date: Thu, 3 Apr 2008 20:25:44 -0700 > From: "Doug Evans" > Cc: gdb-patches@sourceware.org > > Not well enough I'm afraid. Messed up a comment (in front of > disassemble_command). Here's an improved version. Thanks! > c = add_com ("disassemble", class_vars, disassemble_command, _("\ > Disassemble a specified section of memory.\n\ > Default is the function surrounding the pc of the selected frame.\n\ > +With a leading /s modifier source lines, if available, are included.\n\ Why do you say ``leading /s''? What would /s be leading? > This specialized command dumps a range of memory as machine > -instructions. The default memory range is the function surrounding the > +instructions. It can also print mixed source+disassembly by specifying > +the @code{/s} modifier. An example would be good here, and the optional modifier should be mentioned in the @item line above. Other than that, the patch for gdb.texinfo is approved. Thanks.