Re: Fwd: [RFA] mixed source+assembly from cli disassemble

[Eli Zaretskii <eliz@gnu.org>]

> Date: Mon, 28 Apr 2008 07:13:05 -0700
> From: "Doug Evans" <dje@google.com>
> Cc: "Joel Brobecker" <brobecker@adacore.com>,
>         "GDB Patches" <gdb-patches@sourceware.org>
> 
> Ping.  Eli, Joel requests review of the doc parts of this patch.

Yes, sorry I missed it.

> > >    c = add_com ("disassemble", class_vars, disassemble_command, _("\
> >  >  Disassemble a specified section of memory.\n\
> >  >  Default is the function surrounding the pc of the selected frame.\n\
> >  > +With a /m modifier source lines, if available, are included.\n\
> >
> >  I'd like to have Eli's feedback on this change. I would phrase
> >  differently (the current form is missing a coma to make it
> >  intelligible):
> >
> >   With a /m modifier, source lines are included (if available).

I like the latter wording better, too.

>  @item disassemble
> +@itemx disassemble /@var{m}

It is wrong to use @var here, because "/m" is a literal string, it
doesn't stand for anything else.

Other than that, I'm okay with the doco changes.  Thanks.