From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-55517-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 10410 invoked by alias); 28 Apr 2008 19:02:57 -0000
Received: (qmail 10319 invoked by uid 22791); 28 Apr 2008 19:02:56 -0000
X-Spam-Check-By: sourceware.org
Received: from mtaout7.012.net.il (HELO mtaout7.012.net.il) (84.95.2.19)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 28 Apr 2008 19:02:36 +0000
Received: from HOME-C4E4A596F7 ([84.229.228.217]) by i-mtaout7.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0K0100GZGT8RH100@i-mtaout7.012.net.il> for gdb-patches@sourceware.org; Mon, 28 Apr 2008 21:41:33 +0300 (IDT)
Date: Tue, 29 Apr 2008 00:54:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: Fwd: [RFA] mixed source+assembly from cli disassemble
In-reply-to: <e394668d0804280713q1d6419aasfccfaaee0e7d4710@mail.gmail.com>
X-012-Sender: halo1@inter.net.il
To: Doug Evans <dje@google.com>
Cc: brobecker@adacore.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <u3ap5zu0u.fsf@gnu.org>
References: <20080404003857.A5A451C72B9@localhost> <20080416185535.GB3626@adacore.com> <e394668d0804161525t337703a6if245920db61bc225@mail.gmail.com> <e394668d0804280713q1d6419aasfccfaaee0e7d4710@mail.gmail.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-04/txt/msg00641.txt.bz2

> Date: Mon, 28 Apr 2008 07:13:05 -0700
> From: "Doug Evans" <dje@google.com>
> Cc: "Joel Brobecker" <brobecker@adacore.com>,
>         "GDB Patches" <gdb-patches@sourceware.org>
> 
> Ping.  Eli, Joel requests review of the doc parts of this patch.

Yes, sorry I missed it.

> > >    c = add_com ("disassemble", class_vars, disassemble_command, _("\
> >  >  Disassemble a specified section of memory.\n\
> >  >  Default is the function surrounding the pc of the selected frame.\n\
> >  > +With a /m modifier source lines, if available, are included.\n\
> >
> >  I'd like to have Eli's feedback on this change. I would phrase
> >  differently (the current form is missing a coma to make it
> >  intelligible):
> >
> >   With a /m modifier, source lines are included (if available).

I like the latter wording better, too.

>  @item disassemble
> +@itemx disassemble /@var{m}

It is wrong to use @var here, because "/m" is a literal string, it
doesn't stand for anything else.

Other than that, I'm okay with the doco changes.  Thanks.