Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tromey@redhat.com>
Cc: pedro@codesourcery.com, gdb-patches@sourceware.org
Subject: Re: RFA: Patch: implement missing macro functions
Date: Mon, 26 May 2008 16:18:00 -0000	[thread overview]
Message-ID: <u8wy0glpn.fsf@gnu.org> (raw)
In-Reply-To: <m3prrck9ub.fsf@fleche.redhat.com>

> Cc: pedro@codesourcery.com, gdb-patches@sourceware.org
> From: Tom Tromey <tromey@redhat.com>
> Date: Fri, 23 May 2008 15:07:56 -0600
> 
> I fixed all the macro-related uses of @command.

Thanks.

> Here's a new patch.  Let me know what you think.

It's okay, but for a single minor nit:

> +macro define
> +macro list
> +macro undef
> +  These commands are now implemented.  These allow macros to be
> +  defined, undefined, and listed interactively.

I think we should delete the first sentence.  Users who read NEWS do
not know that these commands were documented, but not implemented.
Just saying "These commands allow macros to be defined, undefined, and
listed interactively from within GDB." is enough

Thanks.


  reply	other threads:[~2008-05-24  8:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-21  4:50 Tom Tromey
2008-05-24 15:42 ` Pedro Alves
2008-05-24 16:34   ` Tom Tromey
2008-05-25 12:37   ` Tom Tromey
2008-05-25 18:03     ` Eli Zaretskii
2008-05-25 21:51       ` Tom Tromey
2008-05-26 16:18         ` Eli Zaretskii [this message]
2008-05-26 16:25           ` Tom Tromey
2008-05-25 20:39     ` Pedro Alves
     [not found] ` <8f2776cb0805301626v4ff4d933ua6b833aaa7056aaa@mail.gmail.com>
2008-06-06  0:22   ` Tom Tromey
2008-07-18 20:01     ` Daniel Jacobowitz
2008-07-18 20:56       ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=u8wy0glpn.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox