From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2664 invoked by alias); 24 May 2008 08:18:51 -0000 Received: (qmail 2655 invoked by uid 22791); 24 May 2008 08:18:51 -0000 X-Spam-Check-By: sourceware.org Received: from mtaout6.012.net.il (HELO mtaout6.012.net.il) (84.95.2.16) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 24 May 2008 08:18:24 +0000 Received: from HOME-C4E4A596F7 ([80.230.149.132]) by i-mtaout6.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0K1D00HGQ6DG5M20@i-mtaout6.012.net.il> for gdb-patches@sourceware.org; Sat, 24 May 2008 11:32:05 +0300 (IDT) Date: Mon, 26 May 2008 16:18:00 -0000 From: Eli Zaretskii Subject: Re: RFA: Patch: implement missing macro functions In-reply-to: X-012-Sender: halo1@inter.net.il To: Tom Tromey Cc: pedro@codesourcery.com, gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: References: <200805232030.20677.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00698.txt.bz2 > Cc: pedro@codesourcery.com, gdb-patches@sourceware.org > From: Tom Tromey > Date: Fri, 23 May 2008 15:07:56 -0600 > > I fixed all the macro-related uses of @command. Thanks. > Here's a new patch. Let me know what you think. It's okay, but for a single minor nit: > +macro define > +macro list > +macro undef > + These commands are now implemented. These allow macros to be > + defined, undefined, and listed interactively. I think we should delete the first sentence. Users who read NEWS do not know that these commands were documented, but not implemented. Just saying "These commands allow macros to be defined, undefined, and listed interactively from within GDB." is enough Thanks.