Re: RFA: Patch: implement missing macro functions

[Daniel Jacobowitz <drow@false.org>]

On Thu, Jun 05, 2008 at 06:21:52PM -0600, Tom Tromey wrote:
> Jim sent me a private critique of this patch.  (Thanks Jim.)
> 
> Here is a new version, which I believe addresses all his comments:
> 
> * Don't introduce macro_define_user
> * More comments for macro_for_each
> * macrotab.[ch] should continue to be just opaque macro table type
>   implementation -- put special lookup in macroscope.c and not here
> * Don't export macro_definition_delete
> 
> This required a couple other changes to make it so interactive
> redefinitions did not cause an error -- I decided the cleanest
> approach was to add a new table attribute, then use that.
> 
> Also, I realized a Makefile.in fix was needed.
> 
> Ok?

Since Jim doesn't seem to have further comments, this patch is OK - I
went through it and didn't see anything wrong.
> @@ -1,6 +1,6 @@
>  \input texinfo      @c -*-texinfo-*-
>  @c Copyright (C) 1988, 1989, 1990, 1991, 1992, 1993, 1994, 1995, 1996, 1998,
> -@c 1999, 2000, 2001, 2002, 2003, 2004, 2005, 2006
> +@c 1999, 2000, 2001, 2002, 2003, 2004, 2005, 2006, 2008
>  @c Free Software Foundation, Inc.
>  @c
>  @c %**start of header

Whoops, 2007 also please.

-- 
Daniel Jacobowitz
CodeSourcery