From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4244 invoked by alias); 18 Jul 2008 20:01:16 -0000 Received: (qmail 4235 invoked by uid 22791); 18 Jul 2008 20:01:16 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 18 Jul 2008 20:00:51 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 18F16982C3; Fri, 18 Jul 2008 20:00:50 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id B3FBE98015; Fri, 18 Jul 2008 20:00:49 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KJw8H-0005i5-2w; Fri, 18 Jul 2008 16:00:49 -0400 Date: Fri, 18 Jul 2008 20:01:00 -0000 From: Daniel Jacobowitz To: Tom Tromey Cc: Jim Blandy , gdb-patches@sources.redhat.com Subject: Re: RFA: Patch: implement missing macro functions Message-ID: <20080718200049.GA21350@caradoc.them.org> Mail-Followup-To: Tom Tromey , Jim Blandy , gdb-patches@sources.redhat.com References: <8f2776cb0805301626v4ff4d933ua6b833aaa7056aaa@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00368.txt.bz2 On Thu, Jun 05, 2008 at 06:21:52PM -0600, Tom Tromey wrote: > Jim sent me a private critique of this patch. (Thanks Jim.) > > Here is a new version, which I believe addresses all his comments: > > * Don't introduce macro_define_user > * More comments for macro_for_each > * macrotab.[ch] should continue to be just opaque macro table type > implementation -- put special lookup in macroscope.c and not here > * Don't export macro_definition_delete > > This required a couple other changes to make it so interactive > redefinitions did not cause an error -- I decided the cleanest > approach was to add a new table attribute, then use that. > > Also, I realized a Makefile.in fix was needed. > > Ok? Since Jim doesn't seem to have further comments, this patch is OK - I went through it and didn't see anything wrong. > @@ -1,6 +1,6 @@ > \input texinfo @c -*-texinfo-*- > @c Copyright (C) 1988, 1989, 1990, 1991, 1992, 1993, 1994, 1995, 1996, 1998, > -@c 1999, 2000, 2001, 2002, 2003, 2004, 2005, 2006 > +@c 1999, 2000, 2001, 2002, 2003, 2004, 2005, 2006, 2008 > @c Free Software Foundation, Inc. > @c > @c %**start of header Whoops, 2007 also please. -- Daniel Jacobowitz CodeSourcery