Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] print arrays with indexes
Date: Tue, 20 Sep 2005 19:18:00 -0000	[thread overview]
Message-ID: <u64svim4h.fsf@gnu.org> (raw)
In-Reply-To: <20050920073058.GR2496@adacore.com> (message from Joel Brobecker on Tue, 20 Sep 2005 00:30:58 -0700)

> Date: Tue, 20 Sep 2005 00:30:58 -0700
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: gdb-patches@sources.redhat.com
> 
> Something we haven't really formally decided though, is the significance
> of the threashold. Is it:
> 
>   1. If array size > threshold, then print indexes
>   2. If array size < threshold, then print indexes

The second, I think: it makes sense to ask for arrays that are not too
large to be printed with additional info.

> Now, the sticky part: How to implement this new interface.
> 
> I'll argue that it's best to implement something new. I don't like
> hijacking an old interface to unsigned integer and adding some aliases
> to a couple of values. My reasoning is that saying that OFF is an alias
> for UINT_MAX will make sense for certain cases while it actually won't
> for other cases. Actually, which value to use for OFF will depend on
> the what the threashold actually means.

If you accept my view above, then threshold value of zero means
unlimited.  We already have several set/show commands that behave this
way, so I don't see any problem with having yet another.

> I vote for a new API.

I don't see any reason for a new API.

> I think we should also review the usage of the current ones, probably
> cleanup a bit some of the ones that were on the road to obsolescence
> (IIRC), maybe rationalize a bit more our API if needed, and add some
> documentation. But that should be a separate thread. I don't think I
> will be able to handle all of this, but I can certainly help.

That sounds like a lot of unnecessary work for such an obscure
feature, IMHO.


  reply	other threads:[~2005-09-20 19:18 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-06 20:20 [RFC/RFA] " Joel Brobecker
2005-09-06 20:57 ` Daniel Jacobowitz
2005-09-07  5:40   ` Joel Brobecker
2005-09-07 13:23     ` Daniel Jacobowitz
2005-09-07 20:24       ` Joel Brobecker
2005-09-14 17:13         ` [RFA] " Joel Brobecker
2005-09-17 20:49           ` Daniel Jacobowitz
2005-09-17 21:51             ` Joel Brobecker
2005-09-17 22:07               ` Daniel Jacobowitz
2005-09-18  3:37               ` Eli Zaretskii
2005-09-18  3:46                 ` Daniel Jacobowitz
2005-09-18  5:41                   ` Joel Brobecker
2005-09-18 19:08                     ` Eli Zaretskii
2005-09-18 19:19                       ` Daniel Jacobowitz
2005-09-18 20:05                         ` Eli Zaretskii
2005-09-20  7:31                           ` Joel Brobecker
2005-09-20 19:18                             ` Eli Zaretskii [this message]
2005-09-20 19:31                               ` Joel Brobecker
2005-09-20 19:33                                 ` Daniel Jacobowitz
2005-09-20 19:39                                   ` Joel Brobecker
2005-09-21  3:44                                     ` Eli Zaretskii
2005-09-22 16:47                                     ` Joel Brobecker
2005-09-26  1:23                                       ` Daniel Jacobowitz
2005-09-27  1:04                                         ` Joel Brobecker
2005-10-02 22:42                                           ` Daniel Jacobowitz
2005-10-03  6:17                                             ` Joel Brobecker
2005-10-03 15:50                                               ` Daniel Jacobowitz
2005-10-03 21:23                                                 ` Joel Brobecker
2005-10-04  7:02                                               ` Joel Brobecker
2005-10-04  7:41                                                 ` Joel Brobecker
2005-09-21  3:44                                 ` Eli Zaretskii
2005-09-18  8:53                 ` Mark Kettenis
2005-09-18 19:10                   ` Eli Zaretskii
2005-09-07 20:39       ` [RFC/RFA] " Jim Blandy
2005-09-07 21:41         ` Joel Brobecker
2005-09-09 19:14           ` Jim Blandy
2005-09-06 21:45 ` Jim Blandy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=u64svim4h.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox