From: Daniel Jacobowitz <drow@false.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC/RFA] print arrays with indexes
Date: Wed, 07 Sep 2005 13:23:00 -0000 [thread overview]
Message-ID: <20050907132316.GA3622@nevyn.them.org> (raw)
In-Reply-To: <20050907053951.GC1540@adacore.com>
On Tue, Sep 06, 2005 at 10:39:51PM -0700, Joel Brobecker wrote:
> > So, yes, a language method would be good.
>
> Ok, how about calling it la_print_array_index? The current language_defn
> structure already la_printchar and la_printstr (no "_" between print and
> the object name), but I think using underscores is that much clearer in
> this case.
>
> void (*la_print_array_index) (struct value *index_value,
> struct ui_file *stream,
> int format,
> enum val_prettyprint pretty);
>
> I'll then define a new LA_PRINT_ARRAY_INDEX macro
>
> #define LA_PRINT_ARRAY_INDEX (index_value, stream, format, pretty) \
> (current_language->la_print_array_index(index_value, stream, format, pretty))
Fine with me.
> > > (gdb) set/show print array-indexes
> > >
> > > With a default of "off", to preserve the current behavior.
> >
> > I suppose we've got to :-) I'd turn it on, that's for sure.
>
> There is also Jim's suggestion which has some merits. I'm more of
> an all or nothing kind of guy, so I prefer the approach I've chosen,
> but I am flexible.
I've got no strong opinions on this either way. Thresholds seem
complicated as a UI.
--
Daniel Jacobowitz
CodeSourcery, LLC
next prev parent reply other threads:[~2005-09-07 13:23 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-06 20:20 Joel Brobecker
2005-09-06 20:57 ` Daniel Jacobowitz
2005-09-07 5:40 ` Joel Brobecker
2005-09-07 13:23 ` Daniel Jacobowitz [this message]
2005-09-07 20:24 ` Joel Brobecker
2005-09-14 17:13 ` [RFA] " Joel Brobecker
2005-09-17 20:49 ` Daniel Jacobowitz
2005-09-17 21:51 ` Joel Brobecker
2005-09-17 22:07 ` Daniel Jacobowitz
2005-09-18 3:37 ` Eli Zaretskii
2005-09-18 3:46 ` Daniel Jacobowitz
2005-09-18 5:41 ` Joel Brobecker
2005-09-18 19:08 ` Eli Zaretskii
2005-09-18 19:19 ` Daniel Jacobowitz
2005-09-18 20:05 ` Eli Zaretskii
2005-09-20 7:31 ` Joel Brobecker
2005-09-20 19:18 ` Eli Zaretskii
2005-09-20 19:31 ` Joel Brobecker
2005-09-20 19:33 ` Daniel Jacobowitz
2005-09-20 19:39 ` Joel Brobecker
2005-09-21 3:44 ` Eli Zaretskii
2005-09-22 16:47 ` Joel Brobecker
2005-09-26 1:23 ` Daniel Jacobowitz
2005-09-27 1:04 ` Joel Brobecker
2005-10-02 22:42 ` Daniel Jacobowitz
2005-10-03 6:17 ` Joel Brobecker
2005-10-03 15:50 ` Daniel Jacobowitz
2005-10-03 21:23 ` Joel Brobecker
2005-10-04 7:02 ` Joel Brobecker
2005-10-04 7:41 ` Joel Brobecker
2005-09-21 3:44 ` Eli Zaretskii
2005-09-18 8:53 ` Mark Kettenis
2005-09-18 19:10 ` Eli Zaretskii
2005-09-07 20:39 ` [RFC/RFA] " Jim Blandy
2005-09-07 21:41 ` Joel Brobecker
2005-09-09 19:14 ` Jim Blandy
2005-09-06 21:45 ` Jim Blandy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050907132316.GA3622@nevyn.them.org \
--to=drow@false.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox