From: Eli Zaretskii <eliz@gnu.org>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Document fixed/floating variable objects and thread-id.
Date: Fri, 04 Apr 2008 11:47:00 -0000 [thread overview]
Message-ID: <u63uyt00o.fsf@gnu.org> (raw)
In-Reply-To: <200804041320.00361.vladimir@codesourcery.com> (message from Vladimir Prus on Fri, 4 Apr 2008 13:20:00 +0400)
> From: Vladimir Prus <vladimir@codesourcery.com>
> Date: Fri, 4 Apr 2008 13:20:00 +0400
>
>
> This patch adds some more docs about variable objects.
Thanks, adding documentation is always welcome.
> * gdb/doc/gdb.texinfo (gdb/mi Variable object): Document
> fixed and floating variable objects, and clarify that
> a variable object can also be found to a thread. Update
> -var-create example.
Some comments and suggestions:
> +Variable objects can be either ``fixed'' or ``floating''. For the
Texinfo has a special markup for introducing new terminology: @dfn.
So please use @dfn{fixed} and @dfn{floating}, as it looks better in
print.
Also, there's only one blank after the end of the sentence here;
please use two.
> +fixed variable object, the expression is parsed when the variable
> +object is created, including associating indentifiers to specific
> +variables. The meaning of expression never changes. A floating
> +variable object has its expression reparsed each time the variable
> +object is updated. In particular, the meaning of identifiers can
> +change every time.
Instead of ``meaning'' here, isn't it better to say ``value''?
Other than that, this is approved, thanks.
next prev parent reply other threads:[~2008-04-04 9:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-04 9:32 Vladimir Prus
2008-04-04 11:47 ` Eli Zaretskii [this message]
2008-04-09 13:49 ` Vladimir Prus
2008-04-09 15:21 ` Eli Zaretskii
2008-04-09 17:06 ` Vladimir Prus
2008-04-09 18:04 ` Eli Zaretskii
2008-04-09 20:37 ` Vladimir Prus
2008-04-09 21:25 ` Eli Zaretskii
2008-04-09 22:17 ` Vladimir Prus
2008-04-23 11:52 ` Vladimir Prus
2008-04-23 18:00 ` Eli Zaretskii
2008-04-26 17:44 ` Vladimir Prus
2008-04-26 18:45 ` Eli Zaretskii
2008-04-04 13:08 ` Daniel Jacobowitz
2008-04-04 13:44 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=u63uyt00o.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox