From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2907 invoked by alias); 4 Apr 2008 09:58:25 -0000 Received: (qmail 2899 invoked by uid 22791); 4 Apr 2008 09:58:24 -0000 X-Spam-Check-By: sourceware.org Received: from romy.inter.net.il (HELO romy.inter.net.il) (213.8.233.24) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 04 Apr 2008 09:58:05 +0000 Received: from HOME-C4E4A596F7 (IGLD-84-229-231-225.inter.net.il [84.229.231.225]) by romy.inter.net.il (MOS 3.7.3-GA) with ESMTP id KRK05652 (AUTH halo1); Fri, 4 Apr 2008 12:58:00 +0300 (IDT) Date: Fri, 04 Apr 2008 11:47:00 -0000 Message-Id: From: Eli Zaretskii To: Vladimir Prus CC: gdb-patches@sources.redhat.com In-reply-to: <200804041320.00361.vladimir@codesourcery.com> (message from Vladimir Prus on Fri, 4 Apr 2008 13:20:00 +0400) Subject: Re: [RFA] Document fixed/floating variable objects and thread-id. Reply-to: Eli Zaretskii References: <200804041320.00361.vladimir@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00092.txt.bz2 > From: Vladimir Prus > Date: Fri, 4 Apr 2008 13:20:00 +0400 > > > This patch adds some more docs about variable objects. Thanks, adding documentation is always welcome. > * gdb/doc/gdb.texinfo (gdb/mi Variable object): Document > fixed and floating variable objects, and clarify that > a variable object can also be found to a thread. Update > -var-create example. Some comments and suggestions: > +Variable objects can be either ``fixed'' or ``floating''. For the Texinfo has a special markup for introducing new terminology: @dfn. So please use @dfn{fixed} and @dfn{floating}, as it looks better in print. Also, there's only one blank after the end of the sentence here; please use two. > +fixed variable object, the expression is parsed when the variable > +object is created, including associating indentifiers to specific > +variables. The meaning of expression never changes. A floating > +variable object has its expression reparsed each time the variable > +object is updated. In particular, the meaning of identifiers can > +change every time. Instead of ``meaning'' here, isn't it better to say ``value''? Other than that, this is approved, thanks.