From: Eli Zaretskii <eliz@gnu.org>
To: Markus Deuling <deuling@de.ibm.com>
Cc: gdb-patches@sourceware.org, uweigand@de.ibm.com
Subject: Re: [patch] Remove BITS_BIG_ENDIAN from defs.h
Date: Fri, 11 Jan 2008 20:59:00 -0000 [thread overview]
Message-ID: <u4pdkrscn.fsf@gnu.org> (raw)
In-Reply-To: <4787B2E1.9060809@de.ibm.com> (message from Markus Deuling on Fri, 11 Jan 2008 19:18:09 +0100)
> Date: Fri, 11 Jan 2008 19:18:09 +0100
> From: Markus Deuling <deuling@de.ibm.com>
>
> this patch removes BITS_BIG_ENDIAN from defs.h by replacing it with its expression. The way to recognize
> endianess of a target is gdbarch_byte_order (current_gdbarch) == BFD_ENDIAN_BIG which is widely used by most files.
> So this macro is unnecessary.
Sorry, I don't see how this argument is the proof that the macro is
unnecessary. defs.h allows a target to define BITS_BIG_ENDIAN, and
only looks at gdbarch_byte_order if BITS_BIG_ENDIAN is undefined.
Your change removes that possibility. Why is that justified?
The gdbint.texinfo text you want to remove clearly says that this
macro is for the targets whose bit numbering does NOT match the
endianess of the target itself:
> -@item BITS_BIG_ENDIAN
> -@findex BITS_BIG_ENDIAN
> -Define this if the numbering of bits in the targets does @strong{not} match the
> -endianness of the target byte order.
next prev parent reply other threads:[~2008-01-11 20:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-11 18:20 Markus Deuling
2008-01-11 19:24 ` Daniel Jacobowitz
2008-01-11 20:59 ` Eli Zaretskii [this message]
2008-01-14 18:11 ` Ulrich Weigand
2008-01-15 9:06 ` Markus Deuling
2008-01-15 21:01 ` Ulrich Weigand
2008-01-16 5:59 ` Markus Deuling
2008-01-16 18:43 ` Eli Zaretskii
2008-01-17 7:09 ` Markus Deuling
2008-01-18 16:21 ` Eli Zaretskii
2008-01-18 17:08 ` Markus Deuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=u4pdkrscn.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=deuling@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox