From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-53255-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27187 invoked by alias); 11 Jan 2008 20:59:56 -0000
Received: (qmail 27178 invoked by uid 22791); 11 Jan 2008 20:59:55 -0000
X-Spam-Check-By: sourceware.org
Received: from romy.inter.net.il (HELO romy.inter.net.il) (213.8.233.24)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 11 Jan 2008 20:59:36 +0000
Received: from HOME-C4E4A596F7 (IGLD-80-230-42-152.inter.net.il [80.230.42.152]) 	by romy.inter.net.il (MOS 3.7.3-GA) 	with ESMTP id JWO48359 (AUTH halo1); 	Fri, 11 Jan 2008 22:59:12 +0200 (IST)
Date: Fri, 11 Jan 2008 20:59:00 -0000
Message-Id: <u4pdkrscn.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Markus Deuling <deuling@de.ibm.com>
CC: gdb-patches@sourceware.org, uweigand@de.ibm.com
In-reply-to: <4787B2E1.9060809@de.ibm.com> (message from Markus Deuling on 	Fri, 11 Jan 2008 19:18:09 +0100)
Subject: Re: [patch] Remove BITS_BIG_ENDIAN from defs.h
Reply-to: Eli Zaretskii <eliz@gnu.org>
References:  <4787B2E1.9060809@de.ibm.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-01/txt/msg00287.txt.bz2

> Date: Fri, 11 Jan 2008 19:18:09 +0100
> From: Markus Deuling <deuling@de.ibm.com>
> 
> this patch removes BITS_BIG_ENDIAN from defs.h by replacing it with its expression. The way to recognize
> endianess of a target is gdbarch_byte_order (current_gdbarch) == BFD_ENDIAN_BIG which is widely used by most files.
> So this macro is unnecessary.

Sorry, I don't see how this argument is the proof that the macro is
unnecessary.  defs.h allows a target to define BITS_BIG_ENDIAN, and
only looks at gdbarch_byte_order if BITS_BIG_ENDIAN is undefined.
Your change removes that possibility.  Why is that justified?

The gdbint.texinfo text you want to remove clearly says that this
macro is for the targets whose bit numbering does NOT match the
endianess of the target itself:

> -@item BITS_BIG_ENDIAN
> -@findex BITS_BIG_ENDIAN
> -Define this if the numbering of bits in the targets does @strong{not} match the
> -endianness of the target byte order.