From: Mark Kettenis <kettenis@science.uva.nl>
To: Daniel Jacobowitz <dmj+@andrew.cmu.edu>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] The MIPS/Linux port
Date: Wed, 04 Jul 2001 14:53:00 -0000 [thread overview]
Message-ID: <s3izoakgy74.fsf@soliton.wins.uva.nl> (raw)
In-Reply-To: <20010704121952.A17445@nevyn.them.org>
Looks like the MIPS port was started before a bit of reformatting of
the sources and conversion to ISO C took place. Please
* Format the copyright notice at the beginning of the file as all
(most of) the other files, for example i386-linux-tdep.c.
* Don't put a start on every line of multi-line comments.
* Put two spaces after a full stop (.) in comments, even at the end
of the comment. Make the comments full senteces, including a full
stop at the end of them.
* Wrap long comments.
* Use ISO C prototypes and function definitions, e.g.
int
get_longjmp_target (CORE_ADDR *pc)
{
and
static void fetch_core_registers (char *, unsigned, int, CORE_ADDR);
(get rid of PARAMS).
Good luck!
Mark
next prev parent reply other threads:[~2001-07-04 14:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20010704121952.A17445@nevyn.them.org>
2001-07-04 14:51 ` H . J . Lu
2001-07-04 14:53 ` Mark Kettenis [this message]
2001-07-04 16:34 ` Daniel Jacobowitz
2001-07-05 2:12 ` Mark Kettenis
2001-07-05 16:57 ` John Court
2001-07-05 17:30 ` Daniel Jacobowitz
2001-07-05 17:45 ` John Court
2001-07-05 17:48 ` Daniel Jacobowitz
2001-07-04 23:48 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s3izoakgy74.fsf@soliton.wins.uva.nl \
--to=kettenis@science.uva.nl \
--cc=dmj+@andrew.cmu.edu \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox