Re: [RFA] The MIPS/Linux port

[Daniel Jacobowitz <dmj+@andrew.cmu.edu>]

On Fri, Jul 06, 2001 at 09:57:26AM +1000, John Court wrote:
> Daniel Jacobowitz wrote:
> 
> >On Wed, Jul 04, 2001 at 11:51:27PM +0200, Mark Kettenis wrote:
> >
> >>Looks like the MIPS port was started before a bit of reformatting of
> >>the sources and conversion to ISO C took place.  Please
> >>
> >
> ><snip>
> >
> >Fixed.  Do you see any other formatting problems?
> >
> Hi Daniel,
> 
> You have a bug in your  supply_fpregset() and fill_fpregset()
> routines.  You are being passed an elf_fpregset_t * and incrementing
> the counter by 264 od bytes each time through the loops.  You
> need to offload the arguement something like the following before
> using it with regi.
> 
>   elf_fpreg_t  *fpregp = &(*fpregsetp)[0];
> 
> 
> This wont show up very well until you try and load a core dump
> files which will actually cause gdb to die as it spins off into invalid
> memory.    I would be surprised if your floating point regs in
> gdb look any good the way the code is at the moment.
> I had to look at the assembler to work this out a few days ago.

No, you're wrong.  Note that I say:
  supply_register (FCRCS_REGNUM, (char *)(*fpregsetp + 32));

&(*fpregsetp)[0] is just fancy notation for *fpregsetp, in this case at
least.

I specifcally fixed that bug at least three times :)


-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer