From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark Kettenis <kettenis@science.uva.nl>
To: Daniel Jacobowitz <dmj+@andrew.cmu.edu>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] The MIPS/Linux port
Date: Wed, 04 Jul 2001 14:53:00 -0000
Message-id: <s3izoakgy74.fsf@soliton.wins.uva.nl>
References: <20010704121952.A17445@nevyn.them.org>
X-SW-Source: 2001-07/msg00065.html

Looks like the MIPS port was started before a bit of reformatting of
the sources and conversion to ISO C took place.  Please

 * Format the copyright notice at the beginning of the file as all
   (most of) the other files, for example i386-linux-tdep.c.

 * Don't put a start on every line of multi-line comments.

 * Put two spaces after a full stop (.) in comments, even at the end
   of the comment.  Make the comments full senteces, including a full
   stop at the end of them.

 * Wrap long comments.

 * Use ISO C prototypes and function definitions, e.g.
   
      int
      get_longjmp_target (CORE_ADDR *pc)
      {

   and

      static void fetch_core_registers (char *, unsigned, int, CORE_ADDR);

   (get rid of PARAMS).

Good luck!

Mark