Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <kettenis@science.uva.nl>
To: Kevin Buettner <kevinb@cygnus.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH RFA] lin-lwp.c: Block SIGCHLD events when attaching
Date: Thu, 08 Nov 2001 13:03:00 -0000	[thread overview]
Message-ID: <s3ipu6cfii0.fsf@soliton.wins.uva.nl> (raw)
In-Reply-To: Kevin Buettner's message of Mon, 19 Nov 2001 12:30:45 -0700

Kevin Buettner <kevinb@cygnus.com> writes:

> When doing a lin_lwp_attach_lwp(), it is sometimes possible to receive
> a SIGCHLD signal thus causing the waitpid() call to fail with EINTR. 
> This in turn causes the second assert() in lin_lwp_attach_lwp() to
> fail.

Thanks for tracking this down.  Note that getting this EINTR is a
side-effect of the tricks we play with sigsuspend in lin_lwp_wait.

> The fix is below.  Okay to commit?

Looks fine to me.  lin_lwp_attach_lwp() should not be called unless
the inferior is already running so blocking SIGCHLD here is OK.

Mark


  parent reply	other threads:[~2001-11-21 11:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-07 15:07 Kevin Buettner
2001-11-07 15:15 ` H . J . Lu
2001-11-07 19:05   ` Kevin Buettner
2001-11-07 19:37     ` Kevin Buettner
2001-11-07 20:26       ` H . J . Lu
2001-11-07 22:45         ` Kevin Buettner
2001-11-07 22:48           ` Kevin Buettner
2001-11-07 23:21             ` H . J . Lu
2001-11-08 10:55               ` Kevin Buettner
2001-11-08 10:25                 ` H . J . Lu
2001-11-08 13:03 ` Mark Kettenis [this message]
2001-11-08 19:19   ` Kevin Buettner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s3ipu6cfii0.fsf@soliton.wins.uva.nl \
    --to=kettenis@science.uva.nl \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kevinb@cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox