From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9282 invoked by alias); 21 Nov 2001 11:54:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.cygnus.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9152 invoked from network); 21 Nov 2001 11:53:56 -0000 Received: from unknown (HELO mail.science.uva.nl) (146.50.4.51) by sourceware.cygnus.com with SMTP; 21 Nov 2001 11:53:56 -0000 Received: from soliton.wins.uva.nl [146.50.20.20] by mail.science.uva.nl with ESMTP (sendmail 8.11.6/config 11.19). id fALBqt928262; Wed, 21 Nov 2001 12:52:55 +0100 (MET) Received: from localhost by soliton.wins.uva.nl (sendmail 8.11.6/config 11.15). id fALBqto05053; Wed, 21 Nov 2001 12:52:55 +0100 (MET) X-Organisation: Faculty of Science, University of Amsterdam, The Netherlands X-URL: http://www.science.uva.nl/ To: Kevin Buettner Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH RFA] lin-lwp.c: Block SIGCHLD events when attaching References: <1011119193045.ZM16376@ocotillo.lan> From: Mark Kettenis Date: Thu, 08 Nov 2001 13:03:00 -0000 In-Reply-To: Kevin Buettner's message of Mon, 19 Nov 2001 12:30:45 -0700 Message-ID: X-Mailer: Gnus v5.5/Emacs 20.2 X-SW-Source: 2001-11/txt/msg00165.txt.bz2 Kevin Buettner writes: > When doing a lin_lwp_attach_lwp(), it is sometimes possible to receive > a SIGCHLD signal thus causing the waitpid() call to fail with EINTR. > This in turn causes the second assert() in lin_lwp_attach_lwp() to > fail. Thanks for tracking this down. Note that getting this EINTR is a side-effect of the tricks we play with sigsuspend in lin_lwp_wait. > The fix is below. Okay to commit? Looks fine to me. lin_lwp_attach_lwp() should not be called unless the inferior is already running so blocking SIGCHLD here is OK. Mark