Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: David Carlton <carlton@math.stanford.edu>
To: Andrew Cagney <ac131313@redhat.com>
Cc: gdb-patches@sources.redhat.com, Jim Blandy <jimb@redhat.com>,
	Elena Zannoni <ezannoni@redhat.com>
Subject: Re: [rfa] block.{c,h}
Date: Wed, 19 Feb 2003 23:49:00 -0000	[thread overview]
Message-ID: <ro1heaz7rvx.fsf@jackfruit.Stanford.EDU> (raw)
In-Reply-To: <3E541712.4050205@redhat.com>

On Wed, 19 Feb 2003 18:45:22 -0500, Andrew Cagney <ac131313@redhat.com> said:

>> (values.o, valops.o, tracepoint.o, symtab.o, symmisc.o, symfile.o,
>> stack.o, printcmd.o, p-exp.tab.o, parse.o, objfiles.o,
>> objc-exp.tab.o, objc-lang.o, nlmread.o, mips-tdep.o, mdebugread.o,
>> m2-exp.tab.o, linespec.o, jv-lang.o, jv-exp.tab.o, infcmd.o,
>> f-valprint.o, findvar.o, f-exp.tab.o, expprint.o, coffread.o,

> This is written:

> 	(values.o, valops.o, tracepoint.o)
> 	(stack.o, .....)
> 	(.....): Reason for change.

> (please don't ask me why)

Well, font-lock makes it look prettier your way, so that's an argument
for it.

>> * values.c, valops.c, tracepoint.c, symtab.c, symmisc.c,
>> symfile.c, stack.c, printcmd.c, p-exp.y, parse.c, objfiles.c,
>> objc-exp.y, objc-lang.c, nlmread.c, mips-tdep.c, mdebugread.c,

> And I think this:

> 	* values.c, valops.c, ...: Lame excuse :-)
> 	* symfile.c, stack.c, ...: Ditto.

> see further down in change log for examples.

Anal is indeed the right word. :-)  How about this one?

David Carlton
carlton@math.stanford.edu

2003-02-19  David Carlton  <carlton@math.stanford.edu>

	* Makefile.in (SFILES): Add block.c.
	(block_h): New.
	(COMMON_OBS): Add block.o.
	(block.o): New.
	(x86-64-tdep.o): Add $(block_h).
	(values.o, valops.o, tracepoint.o, symtab.o, symmisc.o, symfile.o)
	(stack.o, printcmd.o, p-exp.tab.o, parse.o, objfiles.o)
	(objc-exp.tab.o, objc-lang.o, nlmread.o, mips-tdep.o, mdebugread.o)
	(m2-exp.tab.o, linespec.o, jv-lang.o, jv-exp.tab.o, infcmd.o)
	(f-valprint.o, findvar.o, f-exp.tab.o, expprint.o, coffread.o)
	(c-exp.tab.o, buildsym.o, breakpoint.o, blockframe.o, ax-gdb.o)
	(alpha-tdep.o, ada-lang.o, ada-exp.tab.o, mi-cmd-stack.o): Ditto.
	* value.h: Add opaque declaration for struct block.
	* parser-defs.h, objc-lang.h, buildsym.h, breakpoint.h: Ditto.
	* ada-lang.h: Ditto.
	* x86-64-tdep.c: #include "block.h"
	* values.c, valops.c, tracepoint.c, symtab.c, symmisc.c: Ditto.
	* symfile.c, stack.c, printcmd.c, p-exp.y, parse.c: Ditto.
	* objfiles.c, objc-exp.y, objc-lang.c, nlmread.c: Ditto.
	* mips-tdep.c, mdebugread.c, m2-exp.y, linespec.c: Ditto.
	* jv-lang.c, jv-exp.y, infcmd.c, f-valprint.c: Ditto.
	* findvar.c, f-exp.y, expprint.c, coffread.c, c-exp.y: Ditto.
	* buildsym.c, breakpoint.c, blockframe.c, ax-gdb.c: Ditto.
	* alpha-tdep.c, ada-lang.c, ada-exp.y: Ditto.
	* blockframe.c (blockvector_for_pc_sect): Move to "block.c".
	(blockvector_for_pc, block_for_pc_sect, block_for_pc): Ditto.
	* symtab.c (block_function): Ditto.
	(contained_in): Ditto.
	* frame.h: Move block_for_pc and block_for_pc_sect declarations to
	block.h.  Add opaque declaration for struct block.
	* symtab.h: Move block_function and contained_in declarations to
	block.h.  Add opaque declarations for struct block, struct
	blockvector.
	(struct block): Move to block.h.
	(struct blockvector): Ditto.
	(BLOCK_START, BLOCK_END, BLOCK_FUNCTION, BLOCK_SUPERBLOCK)
	(BLOCK_GCC_COMPILED, BLOCK_HASHTABLE, BLOCK_NSYMS, BLOCK_SYM)
	(BLOCK_BUCKETS, BLOCK_BUCKET, BLOCK_HASHTABLE_SIZE)
	(ALL_BLOCK_SYMBOLS, BLOCK_SHOULD_SORT, BLOCKVECTOR_NBLOCKS)
	(BLOCKVECTOR_BLOCK, GLOBAL_BLOCK, STATIC_BLOCK, FIRST_LOCAL_BLOCK):
	Ditto.
	* block.c: New file.
	* block.h: New file.


  reply	other threads:[~2003-02-19 23:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-19 22:59 David Carlton
2003-02-19 23:15 ` Andrew Cagney
2003-02-19 23:27   ` David Carlton
2003-02-19 23:40     ` Andrew Cagney
2003-02-19 23:49       ` David Carlton [this message]
2003-02-19 23:56         ` Andrew Cagney
2003-02-20  0:01           ` David Carlton
2003-02-19 23:36   ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ro1heaz7rvx.fsf@jackfruit.Stanford.EDU \
    --to=carlton@math.stanford.edu \
    --cc=ac131313@redhat.com \
    --cc=ezannoni@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jimb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox