From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5709 invoked by alias); 19 Feb 2003 23:49:54 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5702 invoked from network); 19 Feb 2003 23:49:53 -0000 Received: from unknown (HELO jackfruit.Stanford.EDU) (171.64.38.136) by 172.16.49.205 with SMTP; 19 Feb 2003 23:49:53 -0000 Received: (from carlton@localhost) by jackfruit.Stanford.EDU (8.11.6/8.11.6) id h1JNnd211194; Wed, 19 Feb 2003 15:49:39 -0800 X-Authentication-Warning: jackfruit.Stanford.EDU: carlton set sender to carlton@math.stanford.edu using -f To: Andrew Cagney Cc: gdb-patches@sources.redhat.com, Jim Blandy , Elena Zannoni Subject: Re: [rfa] block.{c,h} References: <3E541124.6010203@redhat.com> <3E541712.4050205@redhat.com> From: David Carlton Date: Wed, 19 Feb 2003 23:49:00 -0000 In-Reply-To: <3E541712.4050205@redhat.com> Message-ID: User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Common Lisp) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-02/txt/msg00455.txt.bz2 On Wed, 19 Feb 2003 18:45:22 -0500, Andrew Cagney said: >> (values.o, valops.o, tracepoint.o, symtab.o, symmisc.o, symfile.o, >> stack.o, printcmd.o, p-exp.tab.o, parse.o, objfiles.o, >> objc-exp.tab.o, objc-lang.o, nlmread.o, mips-tdep.o, mdebugread.o, >> m2-exp.tab.o, linespec.o, jv-lang.o, jv-exp.tab.o, infcmd.o, >> f-valprint.o, findvar.o, f-exp.tab.o, expprint.o, coffread.o, > This is written: > (values.o, valops.o, tracepoint.o) > (stack.o, .....) > (.....): Reason for change. > (please don't ask me why) Well, font-lock makes it look prettier your way, so that's an argument for it. >> * values.c, valops.c, tracepoint.c, symtab.c, symmisc.c, >> symfile.c, stack.c, printcmd.c, p-exp.y, parse.c, objfiles.c, >> objc-exp.y, objc-lang.c, nlmread.c, mips-tdep.c, mdebugread.c, > And I think this: > * values.c, valops.c, ...: Lame excuse :-) > * symfile.c, stack.c, ...: Ditto. > see further down in change log for examples. Anal is indeed the right word. :-) How about this one? David Carlton carlton@math.stanford.edu 2003-02-19 David Carlton * Makefile.in (SFILES): Add block.c. (block_h): New. (COMMON_OBS): Add block.o. (block.o): New. (x86-64-tdep.o): Add $(block_h). (values.o, valops.o, tracepoint.o, symtab.o, symmisc.o, symfile.o) (stack.o, printcmd.o, p-exp.tab.o, parse.o, objfiles.o) (objc-exp.tab.o, objc-lang.o, nlmread.o, mips-tdep.o, mdebugread.o) (m2-exp.tab.o, linespec.o, jv-lang.o, jv-exp.tab.o, infcmd.o) (f-valprint.o, findvar.o, f-exp.tab.o, expprint.o, coffread.o) (c-exp.tab.o, buildsym.o, breakpoint.o, blockframe.o, ax-gdb.o) (alpha-tdep.o, ada-lang.o, ada-exp.tab.o, mi-cmd-stack.o): Ditto. * value.h: Add opaque declaration for struct block. * parser-defs.h, objc-lang.h, buildsym.h, breakpoint.h: Ditto. * ada-lang.h: Ditto. * x86-64-tdep.c: #include "block.h" * values.c, valops.c, tracepoint.c, symtab.c, symmisc.c: Ditto. * symfile.c, stack.c, printcmd.c, p-exp.y, parse.c: Ditto. * objfiles.c, objc-exp.y, objc-lang.c, nlmread.c: Ditto. * mips-tdep.c, mdebugread.c, m2-exp.y, linespec.c: Ditto. * jv-lang.c, jv-exp.y, infcmd.c, f-valprint.c: Ditto. * findvar.c, f-exp.y, expprint.c, coffread.c, c-exp.y: Ditto. * buildsym.c, breakpoint.c, blockframe.c, ax-gdb.c: Ditto. * alpha-tdep.c, ada-lang.c, ada-exp.y: Ditto. * blockframe.c (blockvector_for_pc_sect): Move to "block.c". (blockvector_for_pc, block_for_pc_sect, block_for_pc): Ditto. * symtab.c (block_function): Ditto. (contained_in): Ditto. * frame.h: Move block_for_pc and block_for_pc_sect declarations to block.h. Add opaque declaration for struct block. * symtab.h: Move block_function and contained_in declarations to block.h. Add opaque declarations for struct block, struct blockvector. (struct block): Move to block.h. (struct blockvector): Ditto. (BLOCK_START, BLOCK_END, BLOCK_FUNCTION, BLOCK_SUPERBLOCK) (BLOCK_GCC_COMPILED, BLOCK_HASHTABLE, BLOCK_NSYMS, BLOCK_SYM) (BLOCK_BUCKETS, BLOCK_BUCKET, BLOCK_HASHTABLE_SIZE) (ALL_BLOCK_SYMBOLS, BLOCK_SHOULD_SORT, BLOCKVECTOR_NBLOCKS) (BLOCKVECTOR_BLOCK, GLOBAL_BLOCK, STATIC_BLOCK, FIRST_LOCAL_BLOCK): Ditto. * block.c: New file. * block.h: New file.