Re: [rfa] block.{c,h}

[Andrew Cagney <ac131313@redhat.com>]

(symtabs problem but,) some anal things.
The actual restructuring was previously ok'ed.

> +/* Code dealing with blocks for GDB.
  ..., the GNU debugger.


> +   Copyright 2003 Free Software Foundation, Inc.
> +
> +   This file is part of GDB.
> +
> +   This program is free software; you can redistribute it and/or modify
> +   it under the terms of the GNU General Public License as published by
> +   the Free Software Foundation; either version 2 of the License, or
> +   (at your option) any later version.
> +
> +   This program is distributed in the hope that it will be useful,
> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +   GNU General Public License for more details.
> +
> +   You should have received a copy of the GNU General Public License
> +   along with this program; if not, write to the Free Software
> +   Foundation, Inc., 59 Temple Place - Suite 330,
> +   Boston, MA 02111-1307, USA.  */
> +

#ifndef BLOCK_H
#define BLOCK_H

....
	* Makefile.in (SFILES): block.c

``Add "block.c".''

Complete sentence, leading capital, end in fullstop.  Same for others.

> 	* blockframe.c: Move blockvector_for_pc_sect, blockvector_for_pc,
> 	block_for_pc_sect, block_for_pc to block.c.

Use with the correct changelog format, function names and the like in 
paren vis:

	(blockvector_for_pc_sect): Moved to "block.c".

same for these.

> 	* symtab.c: Move block_function, contained_in to block.c.
> 	* frame.h: Move block_for_pc and block_for_pc_sect declarations to
> 	block.h.  Add opaque declaration for struct block.
> 	* symtab.h: Move block-related stuff to block.h.  Add opaque
> 	declarations for struct block, struct blockvector.

List them.

> 	* block.c: New file.
> 	* block.h: New file.
> 

Squishing the changelog a little wouldn't hurt :-)

Andrew