From: Lancelot SIX <lancelot.six@amd.com>
To: Simon Marchi <simon.marchi@efficios.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2 3/6] gdb/amd-dbgapi: pass amd_dbgapi_inferior_info to process_event_queue
Date: Mon, 16 Jun 2025 11:29:11 +0100 [thread overview]
Message-ID: <qi7quh5sndqqr3kxmqfl7e2mubswyy7riu5zyz2y32nzynt4oi@dflcumswvrvk> (raw)
In-Reply-To: <20250609161004.97787-3-simon.marchi@efficios.com>
On Mon, Jun 09, 2025 at 12:08:59PM -0400, Simon Marchi wrote:
> New in v2: update a comment
>
> A following patch will make process_event_queue access a field of
> amd_dbgapi_inferior_info. Prepare for this by making
> process_event_queue accept an amd_dbgapi_inferior_info object, instead
> of a process id.
>
This looks good to me, thanks.
Approved-by: Lancelot Six <lancelot.six@amd.com>
Best,
Lancelot.
> Change-Id: I9adc491dd1ff64ff74c40aa7662fffb11bd8332b
next prev parent reply other threads:[~2025-06-16 10:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-09 16:08 [PATCH v2 1/6] gdb/amd-dbgapi: remove unnecessary AMD_DBGAPI_EVENT_KIND_NONE argument Simon Marchi
2025-06-09 16:08 ` [PATCH v2 2/6] gdb/amd-dbgapi: add assert in require_forward_progress Simon Marchi
2025-06-09 16:08 ` [PATCH v2 3/6] gdb/amd-dbgapi: pass amd_dbgapi_inferior_info to process_event_queue Simon Marchi
2025-06-16 10:29 ` Lancelot SIX [this message]
2025-06-09 16:09 ` [PATCH v2 4/6] gdb/amd-dbgapi: pass amd_dbgapi_inferior_info to process_one_event Simon Marchi
2025-06-16 10:32 ` Lancelot SIX
2025-06-16 14:24 ` Simon Marchi
2025-06-09 16:09 ` [PATCH v2 5/6] gdb/amd-dbgapi: factor out require_forward_progress overload to target one inferior Simon Marchi
2025-06-09 16:09 ` [PATCH v2 6/6] gdb/amd-dbgapi: disable forward progress requirement in amd_dbgapi_target_breakpoint::check_status Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=qi7quh5sndqqr3kxmqfl7e2mubswyy7riu5zyz2y32nzynt4oi@dflcumswvrvk \
--to=lancelot.six@amd.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox