From: Simon Marchi <simark@simark.ca>
To: Lancelot SIX <lancelot.six@amd.com>,
Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 4/6] gdb/amd-dbgapi: pass amd_dbgapi_inferior_info to process_one_event
Date: Mon, 16 Jun 2025 10:24:29 -0400 [thread overview]
Message-ID: <5494c091-5130-442c-bbde-1687af6fb639@simark.ca> (raw)
In-Reply-To: <rk2xk5bifjeusg2fmhonbl4axpoebm6r5bo3f6fleque5wubka@2s3hf2lbgffu>
On 6/16/25 6:32 AM, Lancelot SIX wrote:
> The indentation is off here. When applying the patch, GIT warns about
> indenting with spaces:
>
> .../binutils-gdb/rebase-apply/patch:69: indent with spaces.
> thread_info *thread =
> .../binutils-gdb/rebase-apply/patch:70: indent with spaces.
> info.inf->process_target()->find_thread(event_ptid);
> .../binutils-gdb/rebase-apply/patch:71: indent with spaces.
> if (thread == nullptr)
> warning: 3 lines add whitespace errors.
>
> Also, the `=` symbol should be after the newline, not just before it.
>
> With those style issues fixed, this looks good to me, thanks.
>
> Approved-by: Lancelot Six <lancelot.six@amd.com> (amdgpu)
Thanks, fixed those and pushed the series.
Simon
next prev parent reply other threads:[~2025-06-16 14:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-09 16:08 [PATCH v2 1/6] gdb/amd-dbgapi: remove unnecessary AMD_DBGAPI_EVENT_KIND_NONE argument Simon Marchi
2025-06-09 16:08 ` [PATCH v2 2/6] gdb/amd-dbgapi: add assert in require_forward_progress Simon Marchi
2025-06-09 16:08 ` [PATCH v2 3/6] gdb/amd-dbgapi: pass amd_dbgapi_inferior_info to process_event_queue Simon Marchi
2025-06-16 10:29 ` Lancelot SIX
2025-06-09 16:09 ` [PATCH v2 4/6] gdb/amd-dbgapi: pass amd_dbgapi_inferior_info to process_one_event Simon Marchi
2025-06-16 10:32 ` Lancelot SIX
2025-06-16 14:24 ` Simon Marchi [this message]
2025-06-09 16:09 ` [PATCH v2 5/6] gdb/amd-dbgapi: factor out require_forward_progress overload to target one inferior Simon Marchi
2025-06-09 16:09 ` [PATCH v2 6/6] gdb/amd-dbgapi: disable forward progress requirement in amd_dbgapi_target_breakpoint::check_status Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5494c091-5130-442c-bbde-1687af6fb639@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=lancelot.six@amd.com \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox