From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id F8lQGUkpUGgrwxAAWB0awg (envelope-from ) for ; Mon, 16 Jun 2025 10:25:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1750083913; bh=wHkxHXlf+Dhp5pPbKxIivzw/TXoRpRZQfN2D2BRgcCA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=iA2asKbIqK6vctV8Uyk6PxO/g27RLF5NXiVvwzvVFknqolcB8DQ1a6uRiLAOy1biv rljGSn2lHDCkMIohEoWKpbIX6XNjFuCPhsOL7Gx30wWrDdXhW0hwwVIQwKwZnFQ3Uz Pc4yCTV5kjGg1sQGZf70PyefY+5gVYiuYJ48ek2Q= Received: by simark.ca (Postfix, from userid 112) id 5045B1E102; Mon, 16 Jun 2025 10:25:13 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=unavailable autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=sSpSOLWV; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=sJpHnU6W; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 987861E089 for ; Mon, 16 Jun 2025 10:25:12 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3AA9A38CA75F for ; Mon, 16 Jun 2025 14:25:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3AA9A38CA75F Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=sSpSOLWV; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=sJpHnU6W Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 7AE89380BFCC for ; Mon, 16 Jun 2025 14:24:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7AE89380BFCC Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7AE89380BFCC Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1750083875; cv=none; b=owfGMRTcjJETTaNuz8IbWXCRwcA+RLt6rb+m4v1VrFmGUniU9TkoaRQly/rEt/dnkig/lDN2htjgahzlAcWASD/ioxKykHGZAUebggd8DSFcjDqjzCdVo3PH3q90aUYZAoD+dL3IltIwoNPDPQtPxagGedWplv2FRlc0NCu0Lso= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1750083875; c=relaxed/simple; bh=wHkxHXlf+Dhp5pPbKxIivzw/TXoRpRZQfN2D2BRgcCA=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=wcYBgfQCuM3ZTB2h9ayfCn2eheN1bqQKFhzGTiPrEJn/r9mZoMTTRSUcpy5lZbadn3pt2jkKHs2exryr50WP5R/+vxafRbko8VTzf8Ln6MBkhxQnYPUED1wtXn6hxU1KF0a5BUKyDltowTC1eOLVHIIGJlfIMcdcNNhpAs28NlA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7AE89380BFCC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1750083871; bh=wHkxHXlf+Dhp5pPbKxIivzw/TXoRpRZQfN2D2BRgcCA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=sSpSOLWVQTrmNHzUi+3unJGyZNB83NTD1jwW/glL1id3MtSU1Laj6J1xqjQack0RP IWABRLEcgfMoO3Ypj17Wv7og1EpdpCLPNQQemilyjw2U1MV7xnhYXwgMtZyVhzKSfa BoQFdFYId9ZIn7UnU02HNMgE88OLVBi+bd1fZKJA= Received: by simark.ca (Postfix, from userid 112) id EF0A61E11F; Mon, 16 Jun 2025 10:24:31 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1750083870; bh=wHkxHXlf+Dhp5pPbKxIivzw/TXoRpRZQfN2D2BRgcCA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=sJpHnU6WdPcBp3boWoG5AaYKS3SvnyEHQYhWrzv/N2pPyGxTFDAGghw8jdM9OvJlt deZ6ksnoyChz6+L782acptDmfUZdcVAq3wentl/e5VXCPhR+xOhEUpQMMUsrQKTIfE 4wdmspjk7A/+QYfZFt/J5UDCl+dngT9wM0P8D+mo= Received: from [172.16.0.192] (192-222-132-26.qc.cable.ebox.net [192.222.132.26]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 2E4591E089; Mon, 16 Jun 2025 10:24:30 -0400 (EDT) Message-ID: <5494c091-5130-442c-bbde-1687af6fb639@simark.ca> Date: Mon, 16 Jun 2025 10:24:29 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/6] gdb/amd-dbgapi: pass amd_dbgapi_inferior_info to process_one_event To: Lancelot SIX , Simon Marchi Cc: gdb-patches@sourceware.org References: <20250609161004.97787-4-simon.marchi@efficios.com> Content-Language: fr From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 6/16/25 6:32 AM, Lancelot SIX wrote: > The indentation is off here. When applying the patch, GIT warns about > indenting with spaces: > > .../binutils-gdb/rebase-apply/patch:69: indent with spaces. > thread_info *thread = > .../binutils-gdb/rebase-apply/patch:70: indent with spaces. > info.inf->process_target()->find_thread(event_ptid); > .../binutils-gdb/rebase-apply/patch:71: indent with spaces. > if (thread == nullptr) > warning: 3 lines add whitespace errors. > > Also, the `=` symbol should be after the newline, not just before it. > > With those style issues fixed, this looks good to me, thanks. > > Approved-by: Lancelot Six (amdgpu) Thanks, fixed those and pushed the series. Simon