From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mqAqAyzyT2gKiBAAWB0awg (envelope-from ) for ; Mon, 16 Jun 2025 06:30:04 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=Fngq1ixm; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id DECB71E102; Mon, 16 Jun 2025 06:30:03 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-10.1 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D1E441E089 for ; Mon, 16 Jun 2025 06:30:00 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 37916391C4C6 for ; Mon, 16 Jun 2025 10:30:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 37916391C4C6 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=Fngq1ixm Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2060f.outbound.protection.outlook.com [IPv6:2a01:111:f403:2413::60f]) by sourceware.org (Postfix) with ESMTPS id 708513875DB9 for ; Mon, 16 Jun 2025 10:29:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 708513875DB9 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 708513875DB9 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:2413::60f ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1750069764; cv=pass; b=JMDePSjVvKnXkpHibUkhsC4OyBSrJPUKouIfhQVyMnZg76DZEgb8Y0Thj8h2qnP6MCvibWAhOpxut67wfFf7SNaiZzeyU3NIWI6Z5Iffu7XSp9U3Nk3+5sSHhHOAvsuY+p7hXRJHWy28ema+vDxcRV+RRbOg4sewpcoGKXjOcJo= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1750069764; c=relaxed/simple; bh=TZGNHrC7l9Gm6EQiMW6pTdbJnYunAsM/PRi8sXVaius=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=gQyQNk78b2J4cms4bUaAT8iCTHY94I4FiG+4yy8afwJ2zIwD49bvq8ZHQH2jpPhI9m5gR9lMSmTCXSILNousA8H37NehALL9a/cWcgk6hOqEv1i3c+K6TrmBKii0fTOSTH2aPSOxan1E8wzwYbsPwojwxMEU/DNlahv+YxnRINQ= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 708513875DB9 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UkKLMGa5tUh9f1gTMYfMBUlIJ6I++c2sW+TDFepFMaur9gJVLfT1dKb5pElXjm0Wp5v3eKlh3xSXgwhaHPKgxfYpQSwb32RJPQisw0yaVZXE7XXQNsF6LT9LiLRySxyZ/iLazXj/iLhRhWSQztXMWmrneSizRtTkIjaY6WXLGfd/XzI1ZHB+5zticjAT6Y+5t/dRTzJETV8eBvG1Z4MkG45Jjfj0VRGg/hnvVHfUAoZ6bt3/RyAEbkDvp+zURSAWw1XCKuUfL2ZT1sP2forj6fBXGaE6dBLScGOfWI4zj0SE8nAtr1x+9f6W9aH3/a1LpInlTGVaQ7jh4Icngdq4iA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zD+gAo6Hkec7ZemGXzMXJx8BYNJr2XdFvELvbN1RfaM=; b=rqEjvFTxWlhdPZbn9qy8Uh4WUyjgkTbOzMQ7p4yya2SG097DruxiwBFxiaLtU7YKT32FwW0TPad/rhrXZr8EHROvgGxy8kUeWpQpzGmJ5I+d4QZTZLKjjMg4I4Zw3ZH/lwBHvdI3C3VEu79cf4/jWiTOmfzn9L3a/DIuLTZbfi2b5ScMaImsxmN9M0FASkzwT+A7yBROvRssy0fPYCCCdw3bUvQVnHC/K4xpbjXpwHSu9Sf6rHqOZ67/wdMPnKI7afhlH3vyvJcDSYnJ00/C9dOHUx/EG/KmmjwgX3dPMQsyRtTcq1xvgU1UItQLUBUve9wKOJ4qmgTG+D7eNRmJRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=efficios.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zD+gAo6Hkec7ZemGXzMXJx8BYNJr2XdFvELvbN1RfaM=; b=Fngq1ixma33GXCjpQeTQeNG2XfN0N0tCQLTXTi8Vwu1ANX055ZeGZJ/nr/nXCys9OaiuT1YPg/WZOT34uLq7Nocf/CtvGMWoRIXbprMuTzMapT7OWd03sv6hl5xX7sLYo7F+qoAl33pCTym+mHwHBJm3Q0CCrz03iOf+E0J63W0= Received: from BYAPR11CA0041.namprd11.prod.outlook.com (2603:10b6:a03:80::18) by IA0PR12MB8207.namprd12.prod.outlook.com (2603:10b6:208:401::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.30; Mon, 16 Jun 2025 10:29:21 +0000 Received: from CO1PEPF000066EC.namprd05.prod.outlook.com (2603:10b6:a03:80:cafe::44) by BYAPR11CA0041.outlook.office365.com (2603:10b6:a03:80::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8792.35 via Frontend Transport; Mon, 16 Jun 2025 10:29:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1PEPF000066EC.mail.protection.outlook.com (10.167.249.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8835.15 via Frontend Transport; Mon, 16 Jun 2025 10:29:20 +0000 Received: from khazad-dum (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 16 Jun 2025 05:29:19 -0500 Date: Mon, 16 Jun 2025 11:29:11 +0100 From: Lancelot SIX To: Simon Marchi CC: Subject: Re: [PATCH v2 3/6] gdb/amd-dbgapi: pass amd_dbgapi_inferior_info to process_event_queue Message-ID: References: <20250609161004.97787-3-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20250609161004.97787-3-simon.marchi@efficios.com> X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000066EC:EE_|IA0PR12MB8207:EE_ X-MS-Office365-Filtering-Correlation-Id: 9fbcaf35-e8b8-4042-5ccf-08ddacc0a81b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|82310400026|36860700013|1800799024|27256017; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?al7hTeVVuIyCYoOt/NmcPREeOaXhSc4U8otZJS6cJoAtsC0C2bgx1LB/Ee8R?= =?us-ascii?Q?IygXhHLhQrw/XiqiYsi7cwLW65YvWhwIT5ddxaBnAGn4/Ufsgt9EtQ2RMPx8?= =?us-ascii?Q?USXzxsbFzsBsuHU1eK5+3uTAI1p/OuLwAWo2REoyY6/Mj/uHU+/PW2Fr3p3V?= =?us-ascii?Q?D+IpW5fJpcWTDYXfkSNB6yG7u66rz1iJqffEYQ3nPwfIuqwEnkRj7rHC/zib?= =?us-ascii?Q?LBKJBrt1FOO1k97zyiwUcSpnh6G9qd2xkSXL3DNrSJui0tmmoBNbCRPjXL5y?= =?us-ascii?Q?bYWITtIimaqc+ju9F5q9zUZpiX8uascedkzW+pZkoinhRaTXK42nqUQRD9i5?= =?us-ascii?Q?HroSwoZUsVA2FjoYm0vi624xmxurpyQYx5hrxgzExSRqlpgXvYaOlBYfvda3?= =?us-ascii?Q?74N6kOXVusPysKwzcnay0dXnLm7kzZj8mVLwvYF6zi5TaVfyVSHF9lvqCZl9?= =?us-ascii?Q?Lp+zMWwL1ArskBC4oOBqI+RFA9cHKYT0c9XkFKPzOCqUtPVLEgZvD+naFskP?= =?us-ascii?Q?NTkgkF6+dy+MzB3yVrh0OCeWhgurAwJtWwZ+itquFeYYzs/ac0N/9ZbHNYYy?= =?us-ascii?Q?dT51vtdaFAXT+dGe1ourahJtQwMOGsY/cWuAnTtKIh9niLaNWxyLVz4rT4qP?= =?us-ascii?Q?J2+UbkjbemM00ePbt7PmdyNASFzoHC+skA+SvnVL12mxlHTz8eQe7uwinc3A?= =?us-ascii?Q?yPV5riZE6STwDz+J94y5cMr5cz8ylPnrJ92XO6NkWMHCBewTW8Q4WzQTN4Or?= =?us-ascii?Q?p4zY52lLbDMD0E6F55j1mVYzr7J0RlBl8r38TNaBD+07MBekQ0lHPUpO+7gi?= =?us-ascii?Q?pJFA1yaPr1DEXGUkURKGA3qu7w5YrVPWhsiOiZwsb2Pq4UWgY31dlfjk93NG?= =?us-ascii?Q?K+PixyRHniUMzx0OV3pF67zen22GdsamT8LHMIsqVK/qJHRYqAEvCH2keF9q?= =?us-ascii?Q?ydP4luBChIQwpstvZ+CwAqxqy94ug4YSr1Y3LXzLRN/wzu1nxmRgmlCQnfgi?= =?us-ascii?Q?P1kQQ6czCiuVWN/WTuNcKuDrh63357Q3nY9p6egEqhkfr7jtrNR/6j5e5sF6?= =?us-ascii?Q?nnGty5IHY0hOvshNt/MdCsuVgmP1CowXOQ3H1dOsAezFtmDeiC258tg1O6dh?= =?us-ascii?Q?5BwX+jJX6hG0zILW8P5QdUWsgq4em07oiZ9h6CFkUOskd4ddUhBUd32WiqZe?= =?us-ascii?Q?iowmebKONUuHPFUfzTz0UiFeZm9WU6ahHM5o2VbOFHw7igaVoQY2VcfOwYTL?= =?us-ascii?Q?Us2hFt/7Ul3ypocIZXxN1hLolp5fllaQCjRWqRiGm6JQDWmbEbIcc7hrDTT6?= =?us-ascii?Q?Xsdsdd5LoHBf4dsgAsd9nxs4wrQB58D5IBK6E09OsTrs82v25XCmKP58agHe?= =?us-ascii?Q?L57mzmP+U4mp93HTx0mhvOp2wGrl0yWZlp4rb3wjjkxDm53PAoQQwOh0fCpT?= =?us-ascii?Q?ojAkGxYWgm8bP9/pyHW9zzPT4QifMcPXc9bDCzWL4DGUCqB6gAeAmUzUCP41?= =?us-ascii?Q?/BfUlY0Gggm1Uax14DN0IgA9sSQWWcIh+RbXgk73h1UFk+LhjdehwK2rxQ?= =?us-ascii?Q?=3D=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(376014)(82310400026)(36860700013)(1800799024)(27256017); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2025 10:29:20.9090 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9fbcaf35-e8b8-4042-5ccf-08ddacc0a81b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000066EC.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8207 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Mon, Jun 09, 2025 at 12:08:59PM -0400, Simon Marchi wrote: > New in v2: update a comment > > A following patch will make process_event_queue access a field of > amd_dbgapi_inferior_info. Prepare for this by making > process_event_queue accept an amd_dbgapi_inferior_info object, instead > of a process id. > This looks good to me, thanks. Approved-by: Lancelot Six Best, Lancelot. > Change-Id: I9adc491dd1ff64ff74c40aa7662fffb11bd8332b