From: "H.J. Lu" <hjl.tools@gmail.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: GDB <gdb-patches@sourceware.org>
Subject: Re: PATCH: Fix 32bit coredump read on Linux/AVX
Date: Wed, 21 Apr 2010 14:32:00 -0000 [thread overview]
Message-ID: <q2m6dc9ffc81004210732y44793386ub71d659b2873f409@mail.gmail.com> (raw)
In-Reply-To: <20100420184339.GA18641@intel.com>
On Tue, Apr 20, 2010 at 11:43 AM, H.J. Lu <hongjiu.lu@intel.com> wrote:
> On Mon, Apr 19, 2010 at 08:22:34PM -0700, H.J. Lu wrote:
>> Hi,
>>
>> This patch:
>>
>> http://sourceware.org/ml/gdb-patches/2010-04/msg00276.html
>>
>> breaks 32bit coredump read on Linux/AVX since we only dump .reg and
>> .reg-xstate sections on AVX. But i386_linux_core_read_description
>> checks .reg2 and .reg-xfp sections first. Since there are no
>> .reg2 and .reg-xfp sections, NULL is returned and SSE target is used.
>> This patch changes the section check order to .reg-xstate, .reg-xfp,
>> .reg2. OK to install?
>>
>> Thanks.
>>
>
> .reg2 section has x87 regiters on i386 and SSE registers on amd64.
> Here is the updated patch to properly handle it. OK to install?
>
> Thanks.
>
>
> H.J.
> --
> 2010-04-20 H.J. Lu <hongjiu.lu@intel.com>
>
> PR corefiles/11523
> * amd64-linux-tdep.c (amd64_linux_core_read_description): Check
> XCR0 first.
>
> * i386-linux-tdep.c (i386_linux_core_read_xcr0): Return 0 if
> there is no .reg-xstate section.
> (i386_linux_core_read_description): Check XCR0 first.
>
Any suggestions to this patch? Mark, can you comment on this?
Thanks.
--
H.J.
next prev parent reply other threads:[~2010-04-21 14:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-20 3:22 H.J. Lu
2010-04-20 18:43 ` H.J. Lu
2010-04-21 14:32 ` H.J. Lu [this message]
2010-04-21 19:38 ` Mark Kettenis
2010-04-21 20:18 ` H.J. Lu
2010-04-21 20:24 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=q2m6dc9ffc81004210732y44793386ub71d659b2873f409@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox