From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-72360-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 32505 invoked by alias); 21 Apr 2010 14:32:39 -0000
Received: (qmail 32492 invoked by uid 22791); 21 Apr 2010 14:32:39 -0000
X-SWARE-Spam-Status: No, hits=-1.0 required=5.0 	tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SARE_MSGID_LONG45,TW_XF
X-Spam-Check-By: sourceware.org
Received: from mail-vw0-f41.google.com (HELO mail-vw0-f41.google.com) (209.85.212.41)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 21 Apr 2010 14:32:32 +0000
Received: by vws4 with SMTP id 4so868526vws.0         for <gdb-patches@sourceware.org>; Wed, 21 Apr 2010 07:32:30 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.220.44.198 with HTTP; Wed, 21 Apr 2010 07:32:30 -0700 (PDT)
In-Reply-To: <20100420184339.GA18641@intel.com>
References: <20100420032234.GA10544@intel.com> 	 <20100420184339.GA18641@intel.com>
Date: Wed, 21 Apr 2010 14:32:00 -0000
Received: by 10.220.60.140 with SMTP id p12mr5716483vch.177.1271860350313;  	Wed, 21 Apr 2010 07:32:30 -0700 (PDT)
Message-ID: <q2m6dc9ffc81004210732y44793386ub71d659b2873f409@mail.gmail.com>
Subject: Re: PATCH: Fix 32bit coredump read on Linux/AVX
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: GDB <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-04/txt/msg00679.txt.bz2

On Tue, Apr 20, 2010 at 11:43 AM, H.J. Lu <hongjiu.lu@intel.com> wrote:
> On Mon, Apr 19, 2010 at 08:22:34PM -0700, H.J. Lu wrote:
>> Hi,
>>
>> This patch:
>>
>> http://sourceware.org/ml/gdb-patches/2010-04/msg00276.html
>>
>> breaks 32bit coredump read on Linux/AVX since we only dump .reg and
>> .reg-xstate sections on AVX. But i386_linux_core_read_description
>> checks .reg2 and .reg-xfp sections first. Since there are no
>> .reg2 and .reg-xfp sections, NULL is returned and SSE target is used.
>> This patch changes the section check order to .reg-xstate, .reg-xfp,
>> .reg2. =A0OK to install?
>>
>> Thanks.
>>
>
> .reg2 section has x87 regiters on i386 and SSE registers on amd64.
> Here is the updated patch to properly handle it. =A0OK to install?
>
> Thanks.
>
>
> H.J.
> --
> 2010-04-20 =A0H.J. Lu =A0<hongjiu.lu@intel.com>
>
> =A0 =A0 =A0 =A0PR corefiles/11523
> =A0 =A0 =A0 =A0* amd64-linux-tdep.c (amd64_linux_core_read_description): =
Check
> =A0 =A0 =A0 =A0XCR0 first.
>
> =A0 =A0 =A0 =A0* i386-linux-tdep.c (i386_linux_core_read_xcr0): Return 0 =
if
> =A0 =A0 =A0 =A0there is no .reg-xstate section.
> =A0 =A0 =A0 =A0(i386_linux_core_read_description): Check XCR0 first.
>

Any suggestions to this patch? Mark, can you comment on this?

Thanks.


--=20
H.J.